Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: ui/keyboard/keyboard_controller.cc

Issue 826713002: [ChromeOS] Show autofill popup after keyboard (if any) is shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/keyboard/keyboard_controller.cc
diff --git a/ui/keyboard/keyboard_controller.cc b/ui/keyboard/keyboard_controller.cc
index 9c157a388d698481ea2e811d19499389f596b118..8f2720110997d7e1d17e04a94ea1b24e81a7e9e6 100644
--- a/ui/keyboard/keyboard_controller.cc
+++ b/ui/keyboard/keyboard_controller.cc
@@ -245,6 +245,7 @@ KeyboardController::KeyboardController(KeyboardControllerProxy* proxy)
weak_factory_(this) {
CHECK(proxy);
input_method_ = proxy_->GetInputMethod();
+ input_method_->SetSupportsOnScreenKeyboard(true);
input_method_->AddObserver(this);
window_bounds_observer_.reset(new WindowBoundsChangeObserver());
}
@@ -432,6 +433,8 @@ void KeyboardController::OnShowImeIfNeeded() {
ShowKeyboardInternal();
}
+void KeyboardController::OnKeyboardBoundsUnchanged() {}
+
bool KeyboardController::ShouldEnableInsets(aura::Window* window) {
aura::Window *keyboard_window = proxy_->GetKeyboardWindow();
return (keyboard_window->GetRootWindow() == window->GetRootWindow() &&
@@ -478,6 +481,7 @@ void KeyboardController::ShowKeyboardInternal() {
proxy_->ReloadKeyboardIfNeeded();
if (keyboard_visible_) {
+ proxy_->GetInputMethod()->OnKeyboardBoundsUnchanged();
return;
} else if (proxy_->GetKeyboardWindow()->bounds().height() == 0) {
show_on_resize_ = true;

Powered by Google App Engine
This is Rietveld 408576698