ash/magnifier/magnification_controller.cc - Issue 826713002: [ChromeOS] Show autofill popup after keyboard (if any) is shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/magnifier/magnification_controller.cc

Issue 826713002: [ChromeOS] Show autofill popup after keyboard (if any) is shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/magnifier/magnification_controller.cc

diff --git a/ash/magnifier/magnification_controller.cc b/ash/magnifier/magnification_controller.cc

index 68386a9ed934a970f303c5901d855c3b48cc91f0..b8d8178fda34821338d525a816d39ab727bd36c5 100644

--- a/ash/magnifier/magnification_controller.cc

+++ b/ash/magnifier/magnification_controller.cc

@@ -184,6 +184,7 @@ class MagnificationControllerImpl : virtual public MagnificationController,

void OnInputMethodDestroyed(const ui::InputMethod* input_method) override {}

void OnShowImeIfNeeded() override {}

void OnCaretBoundsChanged(const ui::TextInputClient* client) override;

+ void OnKeyboardBoundsUnchanged() override {}

// Target root window. This must not be NULL.

aura::Window* root_window_;

« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/textinput_test_helper.h » ('j') | ui/base/ime/input_method.h » ('J')