[ChromeOS] Show autofill popup after keyboard (if any) is shown.

ui/base/ime/input_method.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_IME_INPUT_METHOD_H_
 #define UI_BASE_IME_INPUT_METHOD_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 60 matching lines @@
 
   // Called when the focused window receives native IME messages that are not
   // translated into other predefined event callbacks. Currently this method is
   // used only for IME functionalities specific to Windows.
   // TODO(ime): Break down these messages into platform-neutral methods.
   virtual bool OnUntranslatedIMEMessage(const base::NativeEvent& event,
                                         NativeEventResult* result) = 0;
 
   // Sets the text input client which receives text input events such as
   // SetCompositionText(). |client| can be NULL. A gfx::NativeWindow which
-  // implementes TextInputClient interface, e.g. NWA and RWHVA, should register
+  // implements TextInputClient interface, e.g. NWA and RWHVA, should register
   // itself by calling the method when it is focused, and unregister itself by
   // calling the method with NULL when it is unfocused.
   virtual void SetFocusedTextInputClient(TextInputClient* client) = 0;
 
   // Detaches and forgets the |client| regardless of whether it has the focus or
   // not.  This method is meant to be called when the |client| is going to be
   // destroyed.
   virtual void DetachTextInputClient(TextInputClient* client) = 0;
 
   // Gets the current text input client. Returns NULL when no client is set.
@@ skipping 37 matching lines @@
   // keyboard event and generate composition or text result.
   // If the input method is inactive, then it's not necessary to inform it the
   // changes of caret bounds and text input type.
   // Note: character results may still be generated and sent to the text input
   // client by calling TextInputClient::InsertChar(), even if the input method
   // is not active.
   virtual bool IsActive() = 0;
 
   // TODO(yoichio): Following 3 methods(GetTextInputType, GetTextInputMode and
   // CanComposeInline) calls client's same method and returns its value. It is
-  // not InputMethod itself's infomation. So rename these to
+  // not InputMethod itself's information. So rename these to
   // GetClientTextInputType and so on.
   // Gets the text input type of the focused text input client. Returns
   // ui::TEXT_INPUT_TYPE_NONE if there is no focused client.
   virtual TextInputType GetTextInputType() const = 0;
 
   // Gets the text input mode of the focused text input client. Returns
   // ui::TEXT_INPUT_TYPE_DEFAULT if there is no focused client.
   virtual TextInputMode GetTextInputMode() const = 0;
 
   // Gets the text input flags of the focused text input client. Returns
   // 0 if there is no focused client.
   virtual int GetTextInputFlags() const = 0;
 
   // Checks if the focused text input client supports inline composition.
   virtual bool CanComposeInline() const = 0;
 
   // Returns true if we know for sure that a candidate window (or IME suggest,
   // etc.) is open.  Returns false if no popup window is open or the detection
   // of IME popups is not supported.
   virtual bool IsCandidatePopupOpen() const = 0;
 
   // Displays an on screen keyboard if enabled.
   virtual void ShowImeIfNeeded() = 0;
 
+  // Called by an on screen keyboard controller to specify whether focusing a
+  // text input element will show the on screen keyboard.
+  virtual void SetSupportsOnScreenKeyboard(bool supported) = 0;

[Shu Chen, 2015/01/06 02:19:51]

As commented by yukawa@, this looks strange.
I suppose this is only for ChromeOS, because for other platforms,
SupportsOnScreenKeyboard() method should use platform dependent APIs instead of
a boolean value set here.

If this is only for ChromeOS, I think it would be better to keep it as ChromeOS
specific logic which is encapsulated in InputMethodChromeOS.
Ideally, we should let InputMethodChromeOS uses keyboard::IsKeyboardEnabled()
directly, but needs to solve the cycled dependency issue, because ui/keyboard
depends on InputMethod stuff.

Note: return value of SupportsOnScreenKeyboard() can be changed at runtime as
ChromeOS supports enabling/disabling A11y VK in chrome://settings.

Your CL will cause a bug:
If user enables A11y VK, SupportsOnScreenKeyboard() returns true.
Later user disables A11y VK, SupportsOnScreenKeyboard() still returns true, but
should return false.

[Shu Chen, 2015/01/06 02:35:25]

A solution just came to my mind to leverage ui::internal::InputMethodDelegate.
1) add SupportsOnScreenKeyboard() method to ui::internal::InputMethodDelegate.
2) InputMethodEventFilter uses keyboard::IsKeyboardEnabled() to implement
SupportsOnScreenKeyboard().
3) use #if defined(OS_CHROMEOS) when necessary.

WDYT?

[Shu Chen, 2015/01/06 02:38:39]

Hold on, there is no platform specific implementations for InputMethodDelegate,
so it's not an appropriate solution to consider other platforms like windows 8.

+
+  // Returns true if focusing a text input element will show an on screen
+  // keyboard.
+  virtual bool SupportsOnScreenKeyboard() const = 0;
+
+  // Called by an on screen keyboard controller when the on screen keyboard was
+  // requested to be shown, but was already showing.
+  virtual void OnKeyboardBoundsUnchanged() = 0;

[Shu Chen, 2015/01/06 02:19:51]

The naming may cause confusion as
InputMethodObserver::OnKeyboardBoundsUnchanged.

Suggest to change it to NotifyKeyboardBoundsUnchanged().

+
   // Management of the observer list.
   virtual void AddObserver(InputMethodObserver* observer) = 0;
   virtual void RemoveObserver(InputMethodObserver* observer) = 0;
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_IME_INPUT_METHOD_H_