Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 826673002: [turbofan] Raise max virtual registers and call parameter limit. (Closed)

Created:
5 years, 12 months ago by Benedikt Meurer
Modified:
5 years, 12 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Raise max virtual registers and call parameter limit. Change InstructionOperand to use a 64-bit field for encoding the operand information instead of the 32-bit field that was used before. Ideally we wouldn't use the Zone-allocated bit field at all, and use an integer instead of the pointer; but that requires fixing the register allocator first, which will take some time. TEST=mjsunit/compiler/regress-3786 BUG=v8:3786 LOG=y Committed: https://crrev.com/b5e8dd0e1228972eb579fd155442c1eb846b286b Cr-Commit-Position: refs/heads/master@{#25941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -14 lines) Patch
M src/compiler/instruction.h View 5 chunks +14 lines, -14 lines 0 comments Download
A test/mjsunit/compiler/regress-3786.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Not the ideal final solution, but way better than the current behavior. Doesn't increase memory ...
5 years, 12 months ago (2014-12-24 17:58:21 UTC) #2
dcarney
lgtm
5 years, 12 months ago (2014-12-24 19:51:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826673002/1
5 years, 12 months ago (2014-12-25 17:50:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-25 18:17:58 UTC) #6
commit-bot: I haz the power
5 years, 12 months ago (2014-12-25 18:18:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5e8dd0e1228972eb579fd155442c1eb846b286b
Cr-Commit-Position: refs/heads/master@{#25941}

Powered by Google App Engine
This is Rietveld 408576698