content/common/gpu/media/v4l2_video_decode_accelerator.cc - Issue 826663002: Support multiple video decoders and encoders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_video_decode_accelerator.cc

Issue 826663002: Support multiple video decoders and encoders (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Pawel's review comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/v4l2_video_decode_accelerator.cc

diff --git a/content/common/gpu/media/v4l2_video_decode_accelerator.cc b/content/common/gpu/media/v4l2_video_decode_accelerator.cc

index 243fee58d2e4fcfccdb336c68fbc8ae54a066352..ab55eb17df6a2df6193cf15d8d491a8c4583f806 100644

--- a/content/common/gpu/media/v4l2_video_decode_accelerator.cc

+++ b/content/common/gpu/media/v4l2_video_decode_accelerator.cc

@@ -74,7 +74,7 @@ struct V4L2VideoDecodeAccelerator::BitstreamBufferRef {

const scoped_refptr<base::MessageLoopProxy> client_message_loop_proxy;

const scoped_ptr<base::SharedMemory> shm;

const size_t size;

- off_t bytes_used;

+ size_t bytes_used;

wuchengli 2014/12/26 09:26:25 why this is changed?

henryhsu 2014/12/26 09:52:11 Compile warning when comparing bytes_used and size

const int32 input_id;

};