Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: content/common/gpu/media/gpu_video_encode_accelerator.h

Issue 826663002: Support multiple video decoders and encoders (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix nits Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/gpu_video_encode_accelerator.h
diff --git a/content/common/gpu/media/gpu_video_encode_accelerator.h b/content/common/gpu/media/gpu_video_encode_accelerator.h
index ca60f6f1c8dcac639a5424a3bc66867e3acf4666..ceb9a2f5be5e4e7ea1756c9d3942f0c2a7e95c4f 100644
--- a/content/common/gpu/media/gpu_video_encode_accelerator.h
+++ b/content/common/gpu/media/gpu_video_encode_accelerator.h
@@ -8,6 +8,7 @@
#include <vector>
#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
#include "base/memory/weak_ptr.h"
#include "content/common/gpu/gpu_command_buffer_stub.h"
#include "gpu/config/gpu_info.h"
@@ -60,14 +61,14 @@ class GpuVideoEncodeAccelerator
// Static query for supported profiles. This query calls the appropriate
// platform-specific version.
static std::vector<gpu::VideoEncodeAcceleratorSupportedProfile>
- GetSupportedProfiles();
+ GetSupportedProfiles();
static std::vector<gpu::VideoEncodeAcceleratorSupportedProfile>
- ConvertMediaToGpuProfiles(const std::vector<
- media::VideoEncodeAccelerator::SupportedProfile>& media_profiles);
+ ConvertMediaToGpuProfiles(const std::vector<
+ media::VideoEncodeAccelerator::SupportedProfile>& media_profiles);
private:
// Create the appropriate platform-specific VEA.
Pawel Osciak 2014/12/26 01:11:36 Please update comments.
henryhsu 2014/12/26 08:40:40 Done.
- static scoped_ptr<media::VideoEncodeAccelerator> CreateEncoder();
+ static ScopedVector<media::VideoEncodeAccelerator> CreateEncoder();
Pawel Osciak 2014/12/26 01:11:36 CreateEncoders
henryhsu 2014/12/26 08:40:40 Done.
// IPC handlers, proxying media::VideoEncodeAccelerator for the renderer
// process.
@@ -96,8 +97,10 @@ class GpuVideoEncodeAccelerator
// |stub_| is destroyed.
GpuCommandBufferStub* stub_;
- // Owned pointer to the underlying VideoEncodeAccelerator.
- scoped_ptr<media::VideoEncodeAccelerator> encoder_;
+ // Owned pointer to all VideoEncodeAccelerator.
Pawel Osciak 2014/12/26 01:11:36 s/pointer/pointers/ s/VideoEncodeAccelerator/Video
henryhsu 2014/12/26 08:40:40 encoder_list is not used.
+ ScopedVector<media::VideoEncodeAccelerator> encoder_list_;
Pawel Osciak 2014/12/26 01:11:36 s/encoder_list_/encoders_/, since it's not a list.
henryhsu 2014/12/26 08:40:40 Done.
+ // Pointer to valid VideoEncodeAccelerator.
Pawel Osciak 2014/12/26 01:11:36 What does "valid" mean here?
henryhsu 2014/12/26 08:40:40 Done.
+ media::VideoEncodeAccelerator* encoder_;
base::Callback<bool(void)> make_context_current_;
// Video encoding parameters.

Powered by Google App Engine
This is Rietveld 408576698