content/common/gpu/media/gpu_video_decode_accelerator.h - Issue 826663002: Support multiple video decoders and encoders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/gpu_video_decode_accelerator.h

Issue 826663002: Support multiple video decoders and encoders (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix nits Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/gpu_video_decode_accelerator.h

diff --git a/content/common/gpu/media/gpu_video_decode_accelerator.h b/content/common/gpu/media/gpu_video_decode_accelerator.h

index e59a76fb5c35169dd4b0fab8cb448e9bc02a46b3..fcd3a3fc341321bb56a8aaa162d000d7c7efd772 100644

--- a/content/common/gpu/media/gpu_video_decode_accelerator.h

+++ b/content/common/gpu/media/gpu_video_decode_accelerator.h

@@ -70,6 +70,9 @@ class GpuVideoDecodeAccelerator

// We only allow self-delete, from OnWillDestroyStub(), after cleanup there.

~GpuVideoDecodeAccelerator() override;

+ // Initialize video decode accelerator.

+ bool InitialDecoder(const media::VideoCodecProfile profile);

Pawel Osciak 2014/12/26 01:11:35 Please explain the return value and more of what t

henryhsu 2014/12/26 08:40:40 Done.

Pawel Osciak 2014/12/26 01:11:35 s/Initial/Initialize/ Also, no need for const.

henryhsu 2014/12/26 08:40:40 Done.

// Handlers for IPC messages.

void OnDecode(base::SharedMemoryHandle handle, int32 id, uint32 size);

void OnAssignPictureBuffers(const std::vector<int32>& buffer_ids,