Support multiple video decoders and encoders

media/video/video_encode_accelerator.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_VIDEO_ENCODE_ACCELERATOR_H_
 #define MEDIA_VIDEO_VIDEO_ENCODE_ACCELERATOR_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 10 matching lines @@
 
 // Video encoder interface.
 class MEDIA_EXPORT VideoEncodeAccelerator {
  public:
   // Specification of an encoding profile supported by an encoder.
   struct SupportedProfile {
     VideoCodecProfile profile;
     gfx::Size max_resolution;
     uint32 max_framerate_numerator;
     uint32 max_framerate_denominator;
+    bool operator< (const SupportedProfile& other) const {
+      return profile < other.profile;

[Pawel Osciak, 2014/12/28 23:28:03]

This is not enough. If encoder A comes first, but supports a smaller range of
resolutions than encoder B, we don't want to dismiss B's capabilities. Same for
framerate.

What we should do is look for profile among the already found profiles, if we
find one, construct a superset of other values and update it.

I'm not sure about having a '<' operator for this, it's is not a behavior one
would expect. I think a regular vector would be small enough to not have a set
at all.

[henryhsu, 2014/12/29 09:43:27]

as discussed, save a list of all profiles if some parameters are different.

+    }
   };
 
   // Enumeration of potential errors generated by the API.
   enum Error {
     // An operation was attempted during an incompatible encoder state.
     kIllegalStateError,
     // Invalid argument was passed to an API method.
     kInvalidArgumentError,
     // A failure occurred at the GPU process or one of its dependencies.
     // Examples of such failures include GPU hardware failures, GPU driver
@@ skipping 120 matching lines @@
 // uses "Destroy()" instead of trying to use the destructor.
 template <>
 struct MEDIA_EXPORT DefaultDeleter<media::VideoEncodeAccelerator> {
  public:
   void operator()(void* video_encode_accelerator) const;
 };
 
 }  // namespace base
 
 #endif  // MEDIA_VIDEO_VIDEO_ENCODE_ACCELERATOR_H_