Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 826633002: In windows printing, convert src bitmap to dest bitmap using CompositeBitmap. (Closed)

Created:
5 years, 12 months ago by Bo Xu
Modified:
5 years, 11 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

In windows printing, convert src bitmap to dest bitmap using CompositeBitmap. When dealing with transparency, the printing procedure will generate a bitmap first, then draw this bitmap in windows DC. The format of source bitmap is argb, but the destination bitmap is rgb. Simply doing memcpy will lose the alpha channel information, so CompositeBitmap function is needed. BUG=412908 R=vitalybuka@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/07f10ae2eede1ad1fbb4424064eaaaa77dfb90d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M fpdfsdk/src/fpdfview.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bo Xu
Hi Vitaly, please take a look at this CL. Thanks!
5 years, 12 months ago (2014-12-24 06:30:22 UTC) #2
Bo Xu
On 2014/12/24 06:30:22, Bo Xu wrote: > Hi Vitaly, please take a look at this ...
5 years, 11 months ago (2014-12-30 18:09:29 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 11 months ago (2015-01-05 05:35:13 UTC) #4
Bo Xu
5 years, 11 months ago (2015-01-05 18:12:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
07f10ae2eede1ad1fbb4424064eaaaa77dfb90d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698