Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 826613004: Use system FreeType (Closed)

Created:
5 years, 11 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use system FreeType on Linux. This saves 406KB in the binary size of the plugin. More importantly, it gets rid of the linker flag preventing bundling PDFium into the Chromium binary. BUG=453844 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/71c24b839498fb89184002ed30fcff353e1e402c

Patch Set 1 : #

Total comments: 3

Patch Set 2 : update GN files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -32 lines) Patch
M BUILD.gn View 1 4 chunks +19 lines, -5 lines 0 comments Download
M core/include/fxge/fx_freetype.h View 1 2 chunks +7 lines, -8 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 10 chunks +0 lines, -14 lines 0 comments Download
M pdfium.gyp View 3 chunks +31 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jam
https://codereview.chromium.org/826613004/diff/120001/core/include/fxge/fx_freetype.h File core/include/fxge/fx_freetype.h (left): https://codereview.chromium.org/826613004/diff/120001/core/include/fxge/fx_freetype.h#oldcode114 core/include/fxge/fx_freetype.h:114: #define FXFT_Get_Face_Internal_Flag(face) ((FT_Face)face)->internal->transform_flags I removed these since these methods ...
5 years, 10 months ago (2015-01-30 22:52:37 UTC) #8
Tom Sepez
Do you need to make the same change to BUILD.gn? https://codereview.chromium.org/826613004/diff/120001/core/include/fxge/fx_freetype.h File core/include/fxge/fx_freetype.h (right): https://codereview.chromium.org/826613004/diff/120001/core/include/fxge/fx_freetype.h#newcode10 ...
5 years, 10 months ago (2015-01-30 22:56:48 UTC) #9
jam
On 2015/01/30 22:56:48, Tom Sepez wrote: > Do you need to make the same change ...
5 years, 10 months ago (2015-01-30 23:04:04 UTC) #10
jam
ptal https://codereview.chromium.org/826613004/diff/120001/core/include/fxge/fx_freetype.h File core/include/fxge/fx_freetype.h (right): https://codereview.chromium.org/826613004/diff/120001/core/include/fxge/fx_freetype.h#newcode10 core/include/fxge/fx_freetype.h:10: #include <ftmm.h> On 2015/01/30 22:56:48, Tom Sepez wrote: ...
5 years, 10 months ago (2015-01-30 23:36:35 UTC) #11
Tom Sepez
On 2015/01/30 23:36:35, jam wrote: > ptal > > https://codereview.chromium.org/826613004/diff/120001/core/include/fxge/fx_freetype.h > File core/include/fxge/fx_freetype.h (right): > ...
5 years, 10 months ago (2015-01-31 00:05:25 UTC) #12
jam
5 years, 10 months ago (2015-01-31 00:55:13 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:140001) manually as
71c24b839498fb89184002ed30fcff353e1e402c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698