Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 826613003: Revert of Vibration API : migrate to device/vibration using mojo. (Closed)

Created:
6 years ago by dcheng
Modified:
6 years ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, blundell, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Vibration API : migrate to device/vibration using mojo. (patchset #26 id:520001 of https://codereview.chromium.org/583663003/) Reason for revert: Android GN debug clobber builds broken Original issue's description: > Vibration API : migrate to device/vibration using mojo. > > Migrate Vibration API to use mojo. This patch does the following: > 1. move Vibration API to device/vibration, > 2. implement a vibration mojo service which is used from platform. > 3. delete old filters and ipc messages. > > BUG=437537 > > Committed: https://crrev.com/8e29c14638adbc5121a1514d041d5287e1116ca2 > Cr-Commit-Position: refs/heads/master@{#307176} TBR=mvanouwerkerk@chromium.org,qsr@chromium.org,darin@chromium.org,mlamouri@chromium.org,blundell@chromium.org,ppi@chromium.org,tsepez@chromium.org,jam@chromium.org,timvolodine@chromium.org NOTREECHECKS=true NOTRY=true BUG=437537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -492 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +2 lines, -4 lines 0 comments Download
A content/browser/vibration/vibration_message_filter.h View 1 chunk +34 lines, -0 lines 0 comments Download
A content/browser/vibration/vibration_message_filter.cc View 1 chunk +67 lines, -0 lines 0 comments Download
A content/browser/vibration/vibration_provider_android.h View 1 chunk +30 lines, -0 lines 0 comments Download
A content/browser/vibration/vibration_provider_android.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +9 lines, -0 lines 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 3 chunks +5 lines, -2 lines 0 comments Download
M content/content_jni.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/VibrationProvider.java View 1 chunk +54 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A content/public/browser/vibration_provider.h View 1 chunk +23 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +3 lines, -13 lines 0 comments Download
D device/vibration/BUILD.gn View 1 chunk +0 lines, -47 lines 0 comments Download
D device/vibration/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D device/vibration/android/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
D device/vibration/android/java/src/org/chromium/device/vibration/VibrationProvider.java View 1 chunk +0 lines, -54 lines 0 comments Download
D device/vibration/android/vibration_jni_registrar.h View 1 chunk +0 lines, -20 lines 0 comments Download
D device/vibration/android/vibration_jni_registrar.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D device/vibration/vibration.gyp View 1 chunk +0 lines, -84 lines 0 comments Download
D device/vibration/vibration_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D device/vibration/vibration_manager.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
D device/vibration/vibration_manager_impl.h View 1 chunk +0 lines, -21 lines 0 comments Download
D device/vibration/vibration_manager_impl_android.h View 1 chunk +0 lines, -33 lines 0 comments Download
D device/vibration/vibration_manager_impl_android.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D device/vibration/vibration_manager_impl_default.cc View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dcheng
6 years ago (2014-12-23 23:53:24 UTC) #1
Created Revert of Vibration API : migrate to device/vibration using mojo.

Powered by Google App Engine
This is Rietveld 408576698