Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 826603002: Revert of Fix Flaky EncryptedMediaTest (Closed)

Created:
6 years ago by jrummell
Modified:
6 years ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix Flaky EncryptedMediaTest (patchset #1 id:1 of https://codereview.chromium.org/823743002/) Reason for revert: This changes introduces a new problem that is breaking the builds (e.g. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Browser%20%281%29/builds/3905). Original issue's description: > Fix Flaky EncryptedMediaTest > > Tests are flaky as setMediaKeys() was not completing before the > "encrypted" event was generated. Change delays setting the video > source until setMediaKeys() completes. > > BUG=444683 > TEST=Failing tests run fine locally > > Committed: https://crrev.com/37edfbac393c04549884ec15ce612a376a5be6ff > Cr-Commit-Position: refs/heads/master@{#309568} TBR=xhwang@chromium.org NOTREECHECKS=true NOTRY=true BUG=444683 Committed: https://crrev.com/95b0f9c82b73a5826fdd509ab4c6e7b1663bd2aa Cr-Commit-Position: refs/heads/master@{#309587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M media/test/data/eme_player_js/player_utils.js View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jrummell
Created Revert of Fix Flaky EncryptedMediaTest
6 years ago (2014-12-23 22:51:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826603002/1
6 years ago (2014-12-23 22:51:49 UTC) #2
xhwang
lgtm
6 years ago (2014-12-23 22:51:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 22:52:47 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-23 22:53:35 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95b0f9c82b73a5826fdd509ab4c6e7b1663bd2aa
Cr-Commit-Position: refs/heads/master@{#309587}

Powered by Google App Engine
This is Rietveld 408576698