Issue 826573002: Revert "Update legacy Tuple-using code."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 826573002: Revert "Update legacy Tuple-using code." (Closed)

Created:
5 years, 12 months ago by Avi (use Gerrit)

Modified:
5 years, 12 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, jln+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Update legacy Tuple-using code." This reverts commit 12f4b98357b9dedc93cb546aac0aece2c8d9e850 BUG=440675, 444827 Committed: https://chromium.googlesource.com/chromium/src/+/85748694f2a119a057088f77f70b97f11607473c

Patch Set 1 #

Created: 5 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1655 lines, -1580 lines)			Patch
M	base/tuple.h	View	1 chunk	+65 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_utility_messages.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ipc/ipc_message_macros.h	View	6 chunks	+17 lines, -18 lines	0 comments	Download
M	ipc/ipc_message_utils.h	View	3 chunks	+58 lines, -58 lines	0 comments	Download
M	sandbox/linux/seccomp-bpf/codegen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/linux/seccomp-bpf/codegen.cc	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	testing/generate_gmock_mutant.py	View	10 chunks	+34 lines, -23 lines	0 comments	Download
M	testing/gmock_mutant.h	View	106 chunks	+1469 lines, -1469 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/85748694f2a119a057088f77f70b97f11607473c Cr-Commit-Position: refs/heads/master@{#309583}

5 years, 12 months ago (2014-12-23 21:24:24 UTC) #1

Avi (use Gerrit)

Committed patchset #1 (id:1) manually as 85748694f2a119a057088f77f70b97f11607473c.

5 years, 12 months ago (2014-12-23 21:24:30 UTC) #2

Avi (use Gerrit)

5 years, 12 months ago (2014-12-23 21:46:04 UTC) #3

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/794073003/ by avi@chromium.org.

The reason for reverting is: The tests should have failed with this. Undoing the
revert..

Expand Messages | Collapse Messages