Remove dead IPC message ChromeViewHostMsg_DidBlockRunningInsecureContent.

Remove dead IPC message ChromeViewHostMsg_DidBlockRunningInsecureContent.

This also removes its handler and associated code. The use of this infobar has
been superseded by an Omnibox decoration and bubble.

BUG=none

Committed: https://crrev.com/e564cc5ffc113d74905e06a02b2a1b750790d94b
Cr-Commit-Position: refs/heads/master@{#313830}

[Robert Sesek, 2015-01-27 19:03:14]

rsesek@chromium.org changed reviewers:
+ felt@chromium.org, pkasting@chromium.org, tsepez@chromium.org

[Robert Sesek, 2015-01-27 19:03:15]

pkasting: infobars/
tsepez: renderer_messages.h
felt: FYI and to make sure you don't intend to resurrect this

[Tom Sepez, 2015-01-27 19:04:47]

RS LGTM on killing code.

[Peter Kasting, 2015-01-27 19:25:22]

So, we have an infobar when we display insecure content, but not when we run it?
 That seems backwards, if anything.  Strange.

Is the "displayed" infobar also going to go away?

LGTM

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
File chrome/browser/infobars/insecure_content_infobar_delegate.cc (right):

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
chrome/browser/infobars/insecure_content_infobar_delegate.cc:28: // from DISPLAY
to RUN.
This comment is no longer applicable and should disappear.

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
chrome/browser/infobars/insecure_content_infobar_delegate.cc:41:
UMA_HISTOGRAM_ENUMERATION("InsecureContentInfoBarDelegateV2",
Nit: If you move this call to the top of the function, you can convert the break
in the loop to a return, and eliminate the conditional on the AddInfoBar() call
below the loop.

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
chrome/browser/infobars/insecure_content_infobar_delegate.cc:43: NUM_EVENTS);
Nit: Could combine this with previous line (several places)

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
File chrome/browser/infobars/insecure_content_infobar_delegate.h (right):

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
chrome/browser/infobars/insecure_content_infobar_delegate.h:17: //
|infobar_service|, may do nothing; otherwise, creates
This comment is no longer accurate, since Create() now always does something. 
How about just:

  // Creates an insecure content infobar and delegate and adds the infobar to
  // |infobar_service|, replacing any existing insecure content infobar.

[Robert Sesek, 2015-01-27 20:33:21]

On 2015/01/27 19:25:22, Peter Kasting wrote:
> So, we have an infobar when we display insecure content, but not when we run
it?
>  That seems backwards, if anything.  Strange.
> 
> Is the "displayed" infobar also going to go away?

Yes, the infobar is going away and most insure content uses the new
Omnibox-based UI. In fact, this infobar is only displayed in a corner case that
we're unsure how to repro. lgarron@ (on CC) was looking into it, after which
this entire infobar class can be removed.

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
File chrome/browser/infobars/insecure_content_infobar_delegate.cc (right):

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
chrome/browser/infobars/insecure_content_infobar_delegate.cc:28: // from DISPLAY
to RUN.
On 2015/01/27 19:25:22, Peter Kasting wrote:
> This comment is no longer applicable and should disappear.

Done.

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
chrome/browser/infobars/insecure_content_infobar_delegate.cc:41:
UMA_HISTOGRAM_ENUMERATION("InsecureContentInfoBarDelegateV2",
On 2015/01/27 19:25:22, Peter Kasting wrote:
> Nit: If you move this call to the top of the function, you can convert the
break
> in the loop to a return, and eliminate the conditional on the AddInfoBar()
call
> below the loop.

Done.

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
chrome/browser/infobars/insecure_content_infobar_delegate.cc:43: NUM_EVENTS);
On 2015/01/27 19:25:22, Peter Kasting wrote:
> Nit: Could combine this with previous line (several places)

Done.

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
File chrome/browser/infobars/insecure_content_infobar_delegate.h (right):

https://codereview.chromium.org/826553003/diff/20001/chrome/browser/infobars/...
chrome/browser/infobars/insecure_content_infobar_delegate.h:17: //
|infobar_service|, may do nothing; otherwise, creates
On 2015/01/27 19:25:22, Peter Kasting wrote:
> This comment is no longer accurate, since Create() now always does something. 
> How about just:
> 
>   // Creates an insecure content infobar and delegate and adds the infobar to
>   // |infobar_service|, replacing any existing insecure content infobar.

Done.

[Robert Sesek, 2015-01-29 23:01:46]

The CQ bit was checked by rsesek@chromium.org

[felt, 2015-01-29 23:02:23]

felt rubber stamp lgtm on deletion

[commit-bot: I haz the power, 2015-01-29 23:02:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/826553003/40001

[commit-bot: I haz the power, 2015-01-29 23:51:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-29 23:53:02]

Patchset 3 (id:??) landed as
https://crrev.com/e564cc5ffc113d74905e06a02b2a1b750790d94b
Cr-Commit-Position: refs/heads/master@{#313830}