Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 826483002: Condition added to prevent lock animation on Supervised User creation. (Closed)

Created:
6 years ago by merkulova
Modified:
5 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Condition added to prevent lock animation on Supervised User creation. BUG=430642 TBR=oshima@chromium.org Committed: https://crrev.com/34195f8c24ba24267674c78d91b887bf3d955ea4 Cr-Commit-Position: refs/heads/master@{#312856}

Patch Set 1 #

Total comments: 2

Patch Set 2 : IsScreenLocked removed. #

Total comments: 3

Patch Set 3 : Comment fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/power_button_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
merkulova
6 years ago (2014-12-23 13:31:45 UTC) #2
dzhioev (left Google)
Please, add a test for this fix to ash/wm/lock_state_controller_unittest.cc https://codereview.chromium.org/826483002/diff/1/ash/wm/power_button_controller.cc File ash/wm/power_button_controller.cc (right): https://codereview.chromium.org/826483002/diff/1/ash/wm/power_button_controller.cc#newcode75 ash/wm/power_button_controller.cc:75: ...
6 years ago (2014-12-23 14:08:52 UTC) #3
dzhioev (left Google)
6 years ago (2014-12-23 14:09:06 UTC) #4
merkulova
+pkotwicz@ Unit test is not useful here, it leads to testing implementation, not behavior. It ...
6 years ago (2014-12-23 14:50:39 UTC) #6
pkotwicz
Replacing myself with derat@ (who is an ash/ OWNER) derat@ wrote most of power_button_controller.cc According ...
6 years ago (2014-12-23 18:40:25 UTC) #8
Daniel Erat
lgtm after you update or revert the comment change https://codereview.chromium.org/826483002/diff/20001/ash/accelerators/accelerator_controller.cc File ash/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/826483002/diff/20001/ash/accelerators/accelerator_controller.cc#newcode1213 ash/accelerators/accelerator_controller.cc:1213: ...
6 years ago (2014-12-23 18:50:47 UTC) #9
merkulova
https://codereview.chromium.org/826483002/diff/20001/ash/accelerators/accelerator_controller.cc File ash/accelerators/accelerator_controller.cc (right): https://codereview.chromium.org/826483002/diff/20001/ash/accelerators/accelerator_controller.cc#newcode1213 ash/accelerators/accelerator_controller.cc:1213: // There is no power in linux desktop, so ...
5 years, 12 months ago (2014-12-24 13:08:34 UTC) #10
dzhioev (left Google)
On 2014/12/24 13:08:34, merkulova wrote: > https://codereview.chromium.org/826483002/diff/20001/ash/accelerators/accelerator_controller.cc > File ash/accelerators/accelerator_controller.cc (right): > > https://codereview.chromium.org/826483002/diff/20001/ash/accelerators/accelerator_controller.cc#newcode1213 > ...
5 years, 11 months ago (2015-01-23 13:12:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826483002/40001
5 years, 11 months ago (2015-01-23 13:13:28 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-23 16:05:29 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 16:06:28 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/34195f8c24ba24267674c78d91b887bf3d955ea4
Cr-Commit-Position: refs/heads/master@{#312856}

Powered by Google App Engine
This is Rietveld 408576698