Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 826453002: Fix forward declarations (Closed)

Created:
6 years ago by Lof
Modified:
6 years ago
Reviewers:
Ian Vollick, danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix forward declarations Fix forward declarations in cc/animation/ R=vollick@chromium.org Committed: https://crrev.com/4ec93bab5a39d674c8aa4102ae4ecb18f972e805 Cr-Commit-Position: refs/heads/master@{#309570}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix forward declarations #

Total comments: 1

Patch Set 3 : Declare return type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M cc/animation/layer_animation_event_observer.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/animation/layer_animation_value_observer.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M cc/animation/layer_animation_value_provider.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Lof
6 years ago (2014-12-23 09:42:41 UTC) #1
Lof
6 years ago (2014-12-23 09:43:39 UTC) #2
danakj
https://codereview.chromium.org/826453002/diff/1/cc/animation/layer_animation_value_observer.h File cc/animation/layer_animation_value_observer.h (left): https://codereview.chromium.org/826453002/diff/1/cc/animation/layer_animation_value_observer.h#oldcode12 cc/animation/layer_animation_value_observer.h:12: class ScrollOffset; can you move this to the gfx ...
6 years ago (2014-12-23 16:18:05 UTC) #4
Lof
Fix
6 years ago (2014-12-23 16:45:32 UTC) #5
danakj
Please update the patch title/description. https://codereview.chromium.org/826453002/diff/20001/cc/animation/layer_animation_value_provider.h File cc/animation/layer_animation_value_provider.h (right): https://codereview.chromium.org/826453002/diff/20001/cc/animation/layer_animation_value_provider.h#newcode9 cc/animation/layer_animation_value_provider.h:9: #include "ui/gfx/geometry/scroll_offset.h" You can ...
6 years ago (2014-12-23 16:47:30 UTC) #6
Lof
Thank you, Dana. Done.
6 years ago (2014-12-23 17:10:24 UTC) #7
danakj
LGTM
6 years ago (2014-12-23 17:12:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826453002/40001
6 years ago (2014-12-23 17:13:17 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-23 19:00:03 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-23 19:01:54 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4ec93bab5a39d674c8aa4102ae4ecb18f972e805
Cr-Commit-Position: refs/heads/master@{#309570}

Powered by Google App Engine
This is Rietveld 408576698