Should not override styleResolverUpdateType to Reset when some existing stylesheet still has @font-…

Should not override styleResolverUpdateType to Reset when some existing stylesheet still has @font-face rule.

BUG=305885, 309370
TEST=fast/css/font-face-html-as-svg.html (Mac)

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162527

[Hajime Morrita, 2013-11-22 05:12:50]

lgtm.

[commit-bot: I haz the power, 2013-11-22 05:13:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tasak@google.com/82643002/1

[esprehn, 2013-11-22 05:13:34]

Can you add a test?

https://codereview.chromium.org/82643002/diff/1/Source/core/dom/StyleSheetCol...
File Source/core/dom/StyleSheetCollection.cpp (left):

https://codereview.chromium.org/82643002/diff/1/Source/core/dom/StyleSheetCol...
Source/core/dom/StyleSheetCollection.cpp:204: change.styleResolverUpdateType =
ResetStyleResolverAndFontSelector;
Just add an else, the ternary makes this a bit harder to read.

[commit-bot: I haz the power, 2013-11-22 05:53:31]

Retried try job too often on linux_blink for step(s) blink_platform_unittests,
webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[tasak, 2013-11-22 06:16:40]

> Can you add a test?

I removed "[Mac] fast/css/font-face-html-as-svg.html [Timeout]" from
TestExpectations.

These patches are for fixing its timeout.

If we still see its timeout, fontSelector() might have duplicate @font-face
rule.

https://codereview.chromium.org/82643002/diff/1/Source/core/dom/StyleSheetCol...
File Source/core/dom/StyleSheetCollection.cpp (left):

https://codereview.chromium.org/82643002/diff/1/Source/core/dom/StyleSheetCol...
Source/core/dom/StyleSheetCollection.cpp:204: change.styleResolverUpdateType =
ResetStyleResolverAndFontSelector;
On 2013/11/22 05:13:35, esprehn wrote:
> Just add an else, the ternary makes this a bit harder to read.

I strongly agree. Done. I missed ")".

[esprehn, 2013-11-22 07:49:14]

lgtm

[commit-bot: I haz the power, 2013-11-22 08:00:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tasak@google.com/82643002/230001

[commit-bot: I haz the power, 2013-11-22 08:57:02]

Change committed as 162527