Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: sky/compositor/surface_holder.h

Issue 826423008: Use local ids for Surfaces APIs that can only apply to local surfaces (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/compositor/layer_host.cc ('k') | sky/compositor/surface_holder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/compositor/surface_holder.h
diff --git a/sky/compositor/surface_holder.h b/sky/compositor/surface_holder.h
index 9bf5ad25f4973c8c2f833047b35419e8786bd39a..78a073f7c5c9b99e6e0e6eb14651740ba1eecb3f 100644
--- a/sky/compositor/surface_holder.h
+++ b/sky/compositor/surface_holder.h
@@ -24,7 +24,6 @@ class SurfaceHolder : public mojo::SurfaceClient {
public:
class Client {
public:
- virtual void OnSurfaceConnectionCreated() = 0;
virtual void OnSurfaceIdAvailable(mojo::SurfaceIdPtr surface_id) = 0;
virtual void ReturnResources(
mojo::Array<mojo::ReturnedResourcePtr> resources) = 0;
@@ -36,8 +35,6 @@ class SurfaceHolder : public mojo::SurfaceClient {
explicit SurfaceHolder(Client* client, mojo::Shell* shell);
~SurfaceHolder() override;
- bool IsReadyForFrame() const;
-
void SetSize(const gfx::Size& size);
void SubmitFrame(mojo::FramePtr frame, const base::Closure& callback);
@@ -47,15 +44,13 @@ class SurfaceHolder : public mojo::SurfaceClient {
void ReturnResources(
mojo::Array<mojo::ReturnedResourcePtr> resources) override;
- void OnSurfaceConnectionCreated(mojo::SurfacePtr surface,
- uint32_t id_namespace);
+ void SetQualifiedId();
Client* client_;
gfx::Size size_;
- scoped_ptr<SurfaceAllocator> surface_allocator_;
- mojo::SurfacesServicePtr surfaces_service_;
+ uint32_t id_namespace_;
+ uint32_t local_id_;
mojo::SurfacePtr surface_;
- mojo::SurfaceIdPtr surface_id_;
base::WeakPtrFactory<SurfaceHolder> weak_factory_;
« no previous file with comments | « sky/compositor/layer_host.cc ('k') | sky/compositor/surface_holder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698