Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: services/surfaces/surfaces_impl.h

Issue 826423008: Use local ids for Surfaces APIs that can only apply to local surfaces (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/native_viewport/viewport_surface.cc ('k') | services/surfaces/surfaces_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/surfaces/surfaces_impl.h
diff --git a/services/surfaces/surfaces_impl.h b/services/surfaces/surfaces_impl.h
index ec68be99ee9e58ec7b7b9f66d9ba389066c84bc3..6b229a1e3055906191627498b5a8a19ee996ae23 100644
--- a/services/surfaces/surfaces_impl.h
+++ b/services/surfaces/surfaces_impl.h
@@ -54,14 +54,14 @@ class SurfacesImpl : public mojo::Surface,
~SurfacesImpl() override;
// Surface implementation.
- void CreateSurface(mojo::SurfaceIdPtr id) override;
- void SubmitFrame(mojo::SurfaceIdPtr id,
+ void CreateSurface(uint32_t local_id) override;
+ void SubmitFrame(uint32_t local_id,
mojo::FramePtr frame,
const mojo::Closure& callback) override;
- void DestroySurface(mojo::SurfaceIdPtr id) override;
+ void DestroySurface(uint32_t local_id) override;
void CreateGLES2BoundSurface(
mojo::CommandBufferPtr gles2_client,
- mojo::SurfaceIdPtr id,
+ uint32_t local_id,
mojo::SizePtr size,
mojo::InterfaceRequest<mojo::ViewportParameterListener> listener_request)
override;
@@ -88,6 +88,8 @@ class SurfacesImpl : public mojo::Surface,
uint32_t id_namespace,
Client* client);
+ cc::SurfaceId QualifyIdentifier(uint32_t local_id);
+
cc::SurfaceManager* manager_;
cc::SurfaceFactory factory_;
uint32_t id_namespace_;
« no previous file with comments | « services/native_viewport/viewport_surface.cc ('k') | services/surfaces/surfaces_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698