Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: services/native_viewport/viewport_surface.h

Issue 826423008: Use local ids for Surfaces APIs that can only apply to local surfaces (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/native_viewport/native_viewport_impl.cc ('k') | services/native_viewport/viewport_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/native_viewport/viewport_surface.h
diff --git a/services/native_viewport/viewport_surface.h b/services/native_viewport/viewport_surface.h
index 329cae51084502f4aee302b9d50156ae057829ff..3739f4916b0acfae0a9e3d35126d17fea8e17948 100644
--- a/services/native_viewport/viewport_surface.h
+++ b/services/native_viewport/viewport_surface.h
@@ -14,16 +14,12 @@
#include "ui/gfx/native_widget_types.h"
#include "ui/gfx/size.h"
-namespace cc {
-class SurfaceIdAllocator;
-}
-
namespace native_viewport {
// This manages the surface that draws to a particular NativeViewport instance.
class ViewportSurface : public mojo::SurfaceClient {
public:
- ViewportSurface(mojo::SurfacesService* surfaces_service,
+ ViewportSurface(mojo::SurfacePtr surface,
mojo::Gpu* gpu_service,
const gfx::Size& size,
cc::SurfaceId child_id);
@@ -34,8 +30,6 @@ class ViewportSurface : public mojo::SurfaceClient {
void SetChildId(cc::SurfaceId child_id);
private:
- void OnSurfaceConnectionCreated(mojo::SurfacePtr surface,
- uint32_t id_namespace);
void BindSurfaceToNativeViewport();
void SubmitFrame();
@@ -48,8 +42,7 @@ class ViewportSurface : public mojo::SurfaceClient {
mojo::Gpu* gpu_service_;
uint64_t widget_id_;
gfx::Size size_;
- scoped_ptr<cc::SurfaceIdAllocator> id_allocator_;
- cc::SurfaceId id_;
+ bool gles2_bound_surface_created_;
cc::SurfaceId child_id_;
base::WeakPtrFactory<ViewportSurface> weak_factory_;
« no previous file with comments | « services/native_viewport/native_viewport_impl.cc ('k') | services/native_viewport/viewport_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698