Use local ids for Surfaces APIs that can only apply to local surfaces

services/view_manager/display_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/view_manager/display_manager.h"
 
 #include "base/numerics/safe_conversions.h"
 #include "cc/surfaces/surface_id_allocator.h"
 #include "mojo/converters/geometry/geometry_type_converters.h"
 #include "mojo/converters/surfaces/surfaces_type_converters.h"
 #include "mojo/public/cpp/application/application_connection.h"
 #include "mojo/services/gpu/public/interfaces/gpu.mojom.h"
 #include "mojo/services/surfaces/public/cpp/surfaces_utils.h"
 #include "mojo/services/surfaces/public/interfaces/quads.mojom.h"
 #include "services/view_manager/connection_manager.h"
 #include "services/view_manager/server_view.h"
 #include "services/view_manager/view_coordinate_conversions.h"
 
 using mojo::Rect;
 using mojo::Size;
 
 namespace view_manager {
 namespace {
 
+static uint32_t kLocalSurfaceID = 1u;
+
 void DrawViewTree(mojo::Pass* pass,
                   const ServerView* view,
                   const gfx::Vector2d& parent_to_root_origin_offset,
                   float opacity) {
   if (!view->visible())
     return;
 
   const gfx::Rect absolute_bounds =
       view->bounds() + parent_to_root_origin_offset;
   std::vector<const ServerView*> children(view->GetChildren());
@@ skipping 34 matching lines @@
 }
 
 }  // namespace
 
 DefaultDisplayManager::DefaultDisplayManager(
     mojo::ApplicationConnection* app_connection,
     const mojo::Callback<void()>& native_viewport_closed_callback)
     : app_connection_(app_connection),
       connection_manager_(nullptr),
       draw_timer_(false, false),
+      id_namespace_(0u),
+      surface_allocated_(false),
       native_viewport_closed_callback_(native_viewport_closed_callback),
       weak_factory_(this) {
   metrics_.size = mojo::Size::New();
   metrics_.size->width = 800;
   metrics_.size->height = 600;
 }
 
 void DefaultDisplayManager::Init(ConnectionManager* connection_manager) {
   connection_manager_ = connection_manager;
   app_connection_->ConnectToService("mojo:native_viewport_service",
                                     &native_viewport_);
   native_viewport_.set_client(this);
   native_viewport_->Create(
       metrics_.size->Clone(),
       base::Bind(&DefaultDisplayManager::OnCreatedNativeViewport,
                  weak_factory_.GetWeakPtr()));
   native_viewport_->Show();
-  app_connection_->ConnectToService("mojo:surfaces_service",
-                                    &surfaces_service_);
-  surfaces_service_->CreateSurfaceConnection(
-      base::Bind(&DefaultDisplayManager::OnSurfaceConnectionCreated,
-                 weak_factory_.GetWeakPtr()));
+
+  app_connection_->ConnectToService("mojo:surfaces_service", &surface_);
+  surface_.set_client(this);
 
   mojo::NativeViewportEventDispatcherPtr event_dispatcher;
   app_connection_->ConnectToService(&event_dispatcher);
   native_viewport_->SetEventDispatcher(event_dispatcher.Pass());
 }
 
 DefaultDisplayManager::~DefaultDisplayManager() {
 }
 
 void DefaultDisplayManager::SchedulePaint(const ServerView* view,
@@ skipping 17 matching lines @@
 }
 
 const mojo::ViewportMetrics& DefaultDisplayManager::GetViewportMetrics() {
   return metrics_;
 }
 
 void DefaultDisplayManager::OnCreatedNativeViewport(
     uint64_t native_viewport_id) {
 }
 
-void DefaultDisplayManager::OnSurfaceConnectionCreated(mojo::SurfacePtr surface,
-                                                       uint32_t id_namespace) {
-  surface_ = surface.Pass();
-  surface_.set_client(this);
-  surface_id_allocator_.reset(new cc::SurfaceIdAllocator(id_namespace));
-  Draw();
-}
-
 void DefaultDisplayManager::Draw() {
-  if (!surface_)
-    return;
-  if (surface_id_.is_null()) {
-    surface_id_ = surface_id_allocator_->GenerateId();
-    surface_->CreateSurface(mojo::SurfaceId::From(surface_id_));
+  if (!surface_allocated_) {
+    surface_->CreateSurface(kLocalSurfaceID);
+    surface_allocated_ = true;
   }
 
   Rect rect;
   rect.width = metrics_.size->width;
   rect.height = metrics_.size->height;
   auto pass = CreateDefaultPass(1, rect);
   pass->damage_rect = Rect::From(dirty_rect_);
 
   DrawViewTree(pass.get(), connection_manager_->root(), gfx::Vector2d(), 1.0f);
 
   auto frame = mojo::Frame::New();
   frame->passes.push_back(pass.Pass());
   frame->resources.resize(0u);
-  surface_->SubmitFrame(mojo::SurfaceId::From(surface_id_), frame.Pass(),
-                        mojo::Closure());
+  surface_->SubmitFrame(kLocalSurfaceID, frame.Pass(), mojo::Closure());
+  dirty_rect_ = gfx::Rect();
 
-  native_viewport_->SubmittedFrame(mojo::SurfaceId::From(surface_id_));
+  if (id_namespace_ == 0u)
+    return;
 
-  dirty_rect_ = gfx::Rect();
+  auto qualified_id = mojo::SurfaceId::New();
+  qualified_id->id_namespace = id_namespace_;
+  qualified_id->local = kLocalSurfaceID;
+  native_viewport_->SubmittedFrame(qualified_id.Pass());
 }
 
 void DefaultDisplayManager::OnDestroyed() {
   // This is called when the native_viewport is torn down before
   // ~DefaultDisplayManager may be called.
   native_viewport_closed_callback_.Run();
 }
 
 void DefaultDisplayManager::OnMetricsChanged(mojo::ViewportMetricsPtr metrics) {
   metrics_.size = metrics->size.Pass();
   metrics_.device_pixel_ratio = metrics->device_pixel_ratio;
   gfx::Rect bounds(metrics_.size.To<gfx::Size>());
   connection_manager_->root()->SetBounds(bounds);
-  if (surface_id_.is_null())
+  if (!surface_allocated_)
     return;
-  surface_->DestroySurface(mojo::SurfaceId::From(surface_id_));
-  surface_id_ = cc::SurfaceId();
+  surface_->DestroySurface(kLocalSurfaceID);
+  surface_allocated_ = false;
   SchedulePaint(connection_manager_->root(), bounds);
 }
 
 void DefaultDisplayManager::SetIdNamespace(uint32_t id_namespace) {
+  id_namespace_ = id_namespace;
+  if (surface_allocated_) {
+    auto qualified_id = mojo::SurfaceId::New();
+    qualified_id->id_namespace = id_namespace_;
+    qualified_id->local = kLocalSurfaceID;
+    native_viewport_->SubmittedFrame(qualified_id.Pass());
+  }
 }
 
 void DefaultDisplayManager::ReturnResources(
     mojo::Array<mojo::ReturnedResourcePtr> resources) {
   DCHECK_EQ(0u, resources.size());
 }
 
 }  // namespace view_manager