Use local ids for Surfaces APIs that can only apply to local surfaces

services/native_viewport/viewport_surface.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/native_viewport/viewport_surface.h"
 
 #include "base/bind.h"
-#include "cc/surfaces/surface_id_allocator.h"
 #include "mojo/converters/geometry/geometry_type_converters.h"
 #include "mojo/converters/surfaces/surfaces_type_converters.h"
 #include "mojo/services/surfaces/public/cpp/surfaces_utils.h"
 #include "ui/gfx/transform.h"
 
 using mojo::Size;
 using mojo::SurfaceId;
 
+static uint32_t kGLES2BoundSurfaceLocalId = 1u;
+
 namespace native_viewport {
 
-ViewportSurface::ViewportSurface(mojo::SurfacesService* surfaces_service,
+ViewportSurface::ViewportSurface(mojo::SurfacePtr surface,
                                  mojo::Gpu* gpu_service,
                                  const gfx::Size& size,
                                  cc::SurfaceId child_id)
-    : gpu_service_(gpu_service),
+    : surface_(surface.Pass()),
+      gpu_service_(gpu_service),
       widget_id_(0u),
       size_(size),
+      gles2_bound_surface_created_(false),
       child_id_(child_id),
       weak_factory_(this) {
-  surfaces_service->CreateSurfaceConnection(
-      base::Bind(&ViewportSurface::OnSurfaceConnectionCreated,
-                 weak_factory_.GetWeakPtr()));
+  surface_.set_client(this);
 }
 
 ViewportSurface::~ViewportSurface() {
 }
 
 void ViewportSurface::SetWidgetId(uint64_t widget_id) {
   widget_id_ = widget_id;
-  if (id_allocator_)
-    BindSurfaceToNativeViewport();
+  BindSurfaceToNativeViewport();
 }
 
 void ViewportSurface::SetSize(const gfx::Size& size) {
   if (size_ == size)
     return;
 
   size_ = size;
-  if (id_.is_null())
+  if (!gles2_bound_surface_created_)
     return;
 
-  surface_->DestroySurface(SurfaceId::From(id_));
+  surface_->DestroySurface(kGLES2BoundSurfaceLocalId);
   if (widget_id_)
     BindSurfaceToNativeViewport();
 }
 
 void ViewportSurface::SetChildId(cc::SurfaceId child_id) {
   child_id_ = child_id;
   SubmitFrame();
 }
 
-void ViewportSurface::OnSurfaceConnectionCreated(mojo::SurfacePtr surface,
-                                                 uint32_t id_namespace) {
-  surface_ = surface.Pass();
-  surface_.set_client(this);
-  id_allocator_.reset(new cc::SurfaceIdAllocator(id_namespace));
-  if (widget_id_ != 0u)
-    BindSurfaceToNativeViewport();
-}
-
 void ViewportSurface::BindSurfaceToNativeViewport() {
   mojo::ViewportParameterListenerPtr listener;
   auto listener_request = GetProxy(&listener);
   mojo::CommandBufferPtr command_buffer;
   gpu_service_->CreateOnscreenGLES2Context(widget_id_, Size::From(size_),
                                            GetProxy(&command_buffer),
                                            listener.Pass());
 
-  id_ = id_allocator_->GenerateId();
-  surface_->CreateGLES2BoundSurface(command_buffer.Pass(), SurfaceId::From(id_),
+  gles2_bound_surface_created_ = true;
+  surface_->CreateGLES2BoundSurface(command_buffer.Pass(),
+                                    kGLES2BoundSurfaceLocalId,
                                     Size::From(size_), listener_request.Pass());
 
   SubmitFrame();
 }
 
 void ViewportSurface::SubmitFrame() {
-  if (child_id_.is_null() || id_.is_null())
+  if (child_id_.is_null() || !gles2_bound_surface_created_)
     return;
 
   auto surface_quad_state = mojo::SurfaceQuadState::New();
   surface_quad_state->surface = SurfaceId::From(child_id_);
 
   gfx::Rect bounds(size_);
 
   auto surface_quad = mojo::Quad::New();
   surface_quad->material = mojo::Material::MATERIAL_SURFACE_CONTENT;
   surface_quad->rect = mojo::Rect::From(bounds);
   surface_quad->opaque_rect = mojo::Rect::From(bounds);
   surface_quad->visible_rect = mojo::Rect::From(bounds);
   surface_quad->needs_blending = true;
   surface_quad->shared_quad_state_index = 0;
   surface_quad->surface_quad_state = surface_quad_state.Pass();
 
   auto pass = CreateDefaultPass(1, *mojo::Rect::From(bounds));
 
   pass->quads.push_back(surface_quad.Pass());
   pass->shared_quad_states.push_back(CreateDefaultSQS(
       *mojo::Size::From(size_)));
 
   auto frame = mojo::Frame::New();
   frame->passes.push_back(pass.Pass());
   frame->resources.resize(0u);
-  surface_->SubmitFrame(SurfaceId::From(id_), frame.Pass(), mojo::Closure());
+  surface_->SubmitFrame(kGLES2BoundSurfaceLocalId, frame.Pass(),
+                        mojo::Closure());
 }
 
 void ViewportSurface::SetIdNamespace(uint32_t id_namespace) {
+  // We never pass our surface ID to anyone else, so we never need to generate a
+  // fully qualified id and thus don't care about our namespace.
 }
 
 void ViewportSurface::ReturnResources(
     mojo::Array<mojo::ReturnedResourcePtr> resources) {
   // We never submit resources so we should never get any back.
   DCHECK_EQ(0u, resources.size());
 }
 
 }  // namespace native_viewport