pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart - Issue 826413003: Use a shared function to represent type substitutions with dynamic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

Issue 826413003: Use a shared function to represent type substitutions with dynamic. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/code_emitter_task.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

index b2c52734aebd91b227ec89744a963de413639186..4370b17f36d6fea2844bd6fd78e7ed38fbc1823c 100644

--- a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

@@ -73,6 +73,12 @@ class Emitter implements emitterTask.Emitter {

}

@override

+ // TODO(herhut): Use a single shared function.

+ js.Expression generateFunctionThatReturnsNull() {

+ return js.js(r"""function() { return null; }""");

floitsch 2015/01/16 16:56:13 Could we make this return `undefined` ? Would make

+ }

+ @override

js.Expression constantReference(ConstantValue value) {

return _emitter.constantEmitter.reference(value);

}

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/code_emitter_task.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »