Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 826393003: Split mojo_nacl.gyp to fix ARM builds. (Closed)

Created:
5 years, 11 months ago by teravest
Modified:
5 years, 11 months ago
Reviewers:
jamesr, Nico, Daniel Erat
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split mojo_nacl.gyp to fix ARM builds. mojo_nacl.gyp has to be split into two gyp files: * One that provides "normal" targets, and * one that provides "untrusted" targets. This is because build/common_untrusted.gypi sets clang=1 for all ARM builds. For untrusted targets, this is reasonable, but this can break ARM builds of chrome for normal targets (by passing clang flags to g++). BUG=445489 Committed: https://crrev.com/39a76697e0fe1769e2ebbcf2c302b02aeedd5ed5 Cr-Commit-Position: refs/heads/master@{#309784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -51 lines) Patch
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_nacl.gyp View 2 chunks +0 lines, -49 lines 0 comments Download
A mojo/mojo_nacl_untrusted.gyp View 1 chunk +67 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests_mojo.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (6 generated)
teravest
5 years, 11 months ago (2014-12-30 18:32:00 UTC) #2
Daniel Erat
lgtm thanks! i'll patch this in to try it out in my chroot
5 years, 11 months ago (2014-12-30 20:29:51 UTC) #3
teravest
+jamesr for mojo GYP files. NaCl supporting logic in gyp files is horrible, and https://chromium.googlesource.com/chromium/src/+/8e2d2b71e51c0022a2ad7b3535122e7ca01ac6db ...
5 years, 11 months ago (2014-12-30 20:47:40 UTC) #5
jamesr
oh my. lgtm
5 years, 11 months ago (2014-12-30 20:54:00 UTC) #6
Daniel Erat
i can confirm that this fixes things for me when building chromeos-chrome for daisy in ...
5 years, 11 months ago (2014-12-30 21:16:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826393003/1
5 years, 11 months ago (2014-12-30 21:18:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/32823)
5 years, 11 months ago (2014-12-30 21:24:14 UTC) #11
teravest
+thakis for build/all.gyp
5 years, 11 months ago (2014-12-30 21:33:48 UTC) #13
Nico
all.gyp rs-lgtm
5 years, 11 months ago (2014-12-30 21:35:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826393003/1
5 years, 11 months ago (2014-12-30 21:37:13 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2014-12-30 22:20:03 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2014-12-30 22:21:02 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39a76697e0fe1769e2ebbcf2c302b02aeedd5ed5
Cr-Commit-Position: refs/heads/master@{#309784}

Powered by Google App Engine
This is Rietveld 408576698