Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 826373003: [Storage] Added blob items count histogram (Closed)

Created:
5 years, 11 months ago by dmurph
Modified:
5 years, 11 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Storage] Added blob items count histogram R=asvitkine, michaeln BUG=375297 Committed: https://crrev.com/4ab290eb5456785c79725e71719c9257dd2212bb Cr-Commit-Position: refs/heads/master@{#310897}

Patch Set 1 #

Total comments: 2

Patch Set 2 : added more description to histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M storage/browser/blob/blob_storage_context.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dmurph
Hello michaeln & asvitkine, This is one more histogram to give us info about the ...
5 years, 11 months ago (2015-01-09 22:31:07 UTC) #1
michaeln
lgtm
5 years, 11 months ago (2015-01-09 22:33:06 UTC) #2
Alexei Svitkine (slow)
lgtm % nit https://codereview.chromium.org/826373003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/826373003/diff/1/tools/metrics/histograms/histograms.xml#newcode36340 tools/metrics/histograms/histograms.xml:36340: + <summary>The number of blob items ...
5 years, 11 months ago (2015-01-09 22:33:47 UTC) #4
dmurph
https://codereview.chromium.org/826373003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/826373003/diff/1/tools/metrics/histograms/histograms.xml#newcode36340 tools/metrics/histograms/histograms.xml:36340: + <summary>The number of blob items in a constructed ...
5 years, 11 months ago (2015-01-09 22:41:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826373003/20001
5 years, 11 months ago (2015-01-09 22:42:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-09 23:56:46 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 23:57:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ab290eb5456785c79725e71719c9257dd2212bb
Cr-Commit-Position: refs/heads/master@{#310897}

Powered by Google App Engine
This is Rietveld 408576698