Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 826353002: Don't supply value for boolean attribute (Closed)

Created:
5 years, 11 months ago by Arjan van Leeuwen
Modified:
5 years, 11 months ago
Reviewers:
tapted, ccameron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't supply value for boolean attribute According to the documentation, "If the attribute is Boolean, do not supply a value because its presence in the attributes array implies a true value." kCGLPFAAllowOfflineRenderers is a Boolean attribute, so adding a value would make it interpret that value as another attribute. BUG= Committed: https://crrev.com/5af45da16e3d03aeb1482ab6d5234b67337bc9f1 Cr-Commit-Position: refs/heads/master@{#309807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ui/accelerated_widget_mac/io_surface_context.mm View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Arjan van Leeuwen
Noticed a small mistake in this source code, something was added to the attributes that ...
5 years, 11 months ago (2014-12-30 08:58:31 UTC) #2
tapted
You'll need ccameron for OWNERS (added), but lgtm Looks like it's been this way for ...
5 years, 11 months ago (2014-12-30 22:19:11 UTC) #4
ccameron
lgtm
5 years, 11 months ago (2014-12-30 23:05:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826353002/1
5 years, 11 months ago (2014-12-31 07:15:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2014-12-31 08:12:31 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2014-12-31 08:13:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5af45da16e3d03aeb1482ab6d5234b67337bc9f1
Cr-Commit-Position: refs/heads/master@{#309807}

Powered by Google App Engine
This is Rietveld 408576698