Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: sky/tools/tester/test_runner.cc

Issue 826343003: Minor improvements to reftests. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Move the check to TestRunner::OnTestComplete so we only assert if we're actually running a pixel/re… Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tests/resources/run-after-display.sky ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/tester/test_runner.cc
diff --git a/sky/tools/tester/test_runner.cc b/sky/tools/tester/test_runner.cc
index 4f948be4c0b4a03c7a2fafc6a72a6b7051beb529..b321badc303ae77693f5ab869a90e816d8388a4d 100644
--- a/sky/tools/tester/test_runner.cc
+++ b/sky/tools/tester/test_runner.cc
@@ -55,6 +55,7 @@ void TestRunner::OnTestComplete(const std::string& test_result,
std::cout << "\nActualHash: FAKEHASHSTUB\n";
std::cout << "Content-Type: image/png\n";
std::cout << "Content-Length: " << pixels.size() << "\n";
+ CHECK(pixels.size()) << "Could not dump pixels. Did you call notifyTestComplete before the first paint?";
std::cout.write(
reinterpret_cast<const char*>(&pixels[0]), pixels.size());
}
« no previous file with comments | « sky/tests/resources/run-after-display.sky ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698