sky/tests/harness/reftest-expected.sky - Issue 826343003: Minor improvements to reftests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/tests/harness/reftest-expected.sky

Issue 826343003: Minor improvements to reftests. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Move the check to TestRunner::OnTestComplete so we only assert if we're actually running a pixel/re… Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/tests/harness/reftest-expected.sky

diff --git a/sky/tests/harness/reftest-expected.sky b/sky/tests/harness/reftest-expected.sky

index 7a7e586c04f026d4e6dcee8bd7fcea0507c1f183..14ac7626afb9c97c9c616cbabd8677c835aaabc5 100644

--- a/sky/tests/harness/reftest-expected.sky

+++ b/sky/tests/harness/reftest-expected.sky

@@ -1,12 +1,9 @@

<foo>

+<import src="../resources/run-after-display.sky" as="runAfterDisplay" />

This is a reftest.

-window.addEventListener('load', function() {

- // TODO(ojan): requestAnimationFrame once we properly pump frames.

- // https://github.com/domokit/mojo/issues/32

- setTimeout(function() {

- internals.notifyTestComplete("");

- }, 100);

-})

+runAfterDisplay(function() {

+ internals.notifyTestComplete("");

+});

</script>

</foo>

« no previous file with comments | « sky/tests/harness/reftest.sky ('k') | sky/tests/harness/reftest-mismatch.sky » ('j') | no next file with comments »