Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: sky/compositor/display_delegate_bitmap.cc

Issue 826343003: Minor improvements to reftests. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/tests/harness/reftest.sky » ('j') | sky/tests/harness/reftest.sky » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/compositor/display_delegate_bitmap.cc
diff --git a/sky/compositor/display_delegate_bitmap.cc b/sky/compositor/display_delegate_bitmap.cc
index 571eda1f5360f3e754a64fbabf1dafe51dbce0e3..4a8a149d47ca1eb7ccad1e07ba22ee4343cc3e12 100644
--- a/sky/compositor/display_delegate_bitmap.cc
+++ b/sky/compositor/display_delegate_bitmap.cc
@@ -22,7 +22,8 @@ DisplayDelegate* DisplayDelegateBitmap::create(LayerClient* client) {
}
void DisplayDelegateBitmap::GetPixelsForTesting(std::vector<unsigned char>* pixels) {
- gfx::PNGCodec::EncodeBGRASkBitmap(bitmap_, false, pixels);
+ bool success = gfx::PNGCodec::EncodeBGRASkBitmap(bitmap_, false, pixels);
+ CHECK(success) << "Could not dump pixels. Did you call notifyTestComplete before the first paint?";
}
void DisplayDelegateBitmap::Paint(mojo::GaneshSurface& surface, const gfx::Rect& size) {
« no previous file with comments | « no previous file | sky/tests/harness/reftest.sky » ('j') | sky/tests/harness/reftest.sky » ('J')

Powered by Google App Engine
This is Rietveld 408576698