Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(893)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: sky/tests/resources/run-after-display.sky
Issue
826343003
:
Minor improvements to reftests. (Closed)
Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Move the check to TestRunner::OnTestComplete so we only assert if we're actually running a pixel/re…
Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
sky/tests/harness/reftest.sky
sky/tests/harness/reftest-expected.sky
sky/tests/harness/reftest-mismatch.sky
sky/tests/harness/reftest-mismatch-expected-mismatch.sky
sky/tests/resources/run-after-display.sky
sky/tools/tester/test_runner.cc
View unified diff
|
Download patch
« no previous file with comments
|
« sky/tests/harness/reftest-mismatch-expected-mismatch.sky
('k') |
sky/tools/tester/test_runner.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<script>
2
module.exports = function(callback) {
3
window.requestAnimationFrame(function() {
4
// At this point, only the animate has happened, but no compositing
5
// or layout. Use a timeout for the callback so that notifyDone
6
// can be called inside of it.
7
// FIXME: we need a better way of waiting for chromium events to happen
8
window.setTimeout(callback);
9
});
10
};
11
</script>
OLD
NEW
« no previous file with comments
|
« sky/tests/harness/reftest-mismatch-expected-mismatch.sky
('k') |
sky/tools/tester/test_runner.cc »
('j') |
no next file with comments »
Issue 826343003: Minor improvements to reftests. (Closed)
Created 5 years, 11 months ago by ojan
Modified 5 years, 11 months ago
Reviewers: abarth-chromium
Base URL: git@github.com:domokit/mojo.git@master
Comments: 5
This is Rietveld
408576698