sky/tests/harness/reftest.sky - Issue 826343003: Minor improvements to reftests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/tests/harness/reftest.sky

Issue 826343003: Minor improvements to reftests. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <foo>	1 <foo>

	2 <import src="../resources/run-after-display.sky" as="runAfterDisplay" />

2 This is a reftest.	3 This is a reftest.

3 <script>	4 <script>

4 window.addEventListener('load', function() {	5 runAfterDisplay(function() {

5 // TODO(ojan): requestAnimationFrame once we properly pump frames.	6 internals.notifyTestComplete("");

6 // https://github.com/domokit/mojo/issues/32	7 });
	abarth-chromium 2015/01/06 22:48:09 Should we move this code into a ref-test.sky resou Should we move this code into a ref-test.sky resource file? ojan 2015/01/06 22:54:41 I considered it and it seemed a bit confusing sinc Show quoted text On 2015/01/06 22:48:09, abarth wrote: > Should we move this code into a ref-test.sky resource file? I considered it and it seemed a bit confusing since it doesn't actually cause the test to be a reftest or to dump pixels even. The thing that causes it to be a reftest is the presence of a -expected.sky file. I don't feel strongly. I'll commit this for now, happy to do this as a followup if you still think it's a good idea.
7 setTimeout(function() {

8 internals.notifyTestComplete("");

9 }, 100);

10 })

11 </script>	8 </script>

12 </foo>	9 </foo>

OLD	NEW