Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 826323002: Add proper path separator(\) for testing AX test cases on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updating Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/accessibility/dump_accessibility_events_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc
diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
index 5262bac174809429d4891c11ce4e5c15e65e2132..ab269f48538fc81bd3d13496db08e71827ff60b2 100644
--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
@@ -66,25 +66,23 @@ class DumpAccessibilityTreeTest : public DumpAccessibilityTestBase {
void RunAriaTest(const base::FilePath::CharType* file_path) {
base::FilePath dir_test_data;
ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &dir_test_data));
- base::FilePath test_path(
- dir_test_data.AppendASCII("accessibility/aria"));
- ASSERT_TRUE(base::PathExists(test_path))
- << test_path.LossyDisplayName();
+ base::FilePath test_path(dir_test_data.AppendASCII("accessibility")
+ .AppendASCII("aria"));
+ ASSERT_TRUE(base::PathExists(test_path)) << test_path.LossyDisplayName();
- base::FilePath aria_file = test_path.Append(base::FilePath(file_path));
- RunTest(aria_file, "accessibility/aria");
+ base::FilePath event_file = test_path.Append(base::FilePath(file_path));
dmazzoni 2015/01/14 18:13:53 nit: this should be aria_file, not event_file
+ RunTest(event_file, "accessibility/aria");
}
void RunHtmlTest(const base::FilePath::CharType* file_path) {
base::FilePath dir_test_data;
ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &dir_test_data));
- base::FilePath test_path(
- dir_test_data.AppendASCII("accessibility/html"));
- ASSERT_TRUE(base::PathExists(test_path))
- << test_path.LossyDisplayName();
+ base::FilePath test_path(dir_test_data.AppendASCII("accessibility")
+ .AppendASCII("html"));
+ ASSERT_TRUE(base::PathExists(test_path)) << test_path.LossyDisplayName();
- base::FilePath html_file = test_path.Append(base::FilePath(file_path));
- RunTest(html_file, "accessibility/html");
+ base::FilePath event_file = test_path.Append(base::FilePath(file_path));
dmazzoni 2015/01/14 18:13:53 should be html_file
+ RunTest(event_file, "accessibility/html");
}
std::vector<std::string> Dump() override {
« no previous file with comments | « content/browser/accessibility/dump_accessibility_events_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698