Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 826323002: Add proper path separator(\) for testing AX test cases on windows. (Closed)

Created:
5 years, 11 months ago by shreeramk
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add proper path separator(\) for testing AX test cases on windows. This CL would make the path separator uniform on windows for AX tests. Presently the test path is coming as follow:This will be executed because windows supports both(\,/) Testing: e:\b\swarm_slave\work\run_tha_testzigska\content\test\data\accessibility/aria\aria-disabled.html But proper would be to keep it uniform. Testing: e:\b\swarm_slave\work\run_tha_testzigska\content\test\data\accessibility\aria\aria-disabled.html BUG=none Committed: https://crrev.com/845a27e777ee5b8ec20deda87001c86ce59fa13e Cr-Commit-Position: refs/heads/master@{#311693}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : updating #

Total comments: 2

Patch Set 4 : fixing nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M content/browser/accessibility/dump_accessibility_events_browsertest.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
shreeramk
Please review. Thanks!!
5 years, 11 months ago (2014-12-30 05:28:59 UTC) #2
dmazzoni
Thanks for the fix, but would be better to reuse existing file path support rather ...
5 years, 11 months ago (2015-01-05 09:04:59 UTC) #3
dmazzoni
Oh, and thanks for your patience - I'm back from vacation and catching up on ...
5 years, 11 months ago (2015-01-05 09:05:33 UTC) #4
shreeramk
@Dominic: PTAL. Thanks!
5 years, 11 months ago (2015-01-12 07:42:31 UTC) #5
dmazzoni
lgtm https://codereview.chromium.org/826323002/diff/40001/content/browser/accessibility/dump_accessibility_tree_browsertest.cc File content/browser/accessibility/dump_accessibility_tree_browsertest.cc (right): https://codereview.chromium.org/826323002/diff/40001/content/browser/accessibility/dump_accessibility_tree_browsertest.cc#newcode73 content/browser/accessibility/dump_accessibility_tree_browsertest.cc:73: base::FilePath event_file = test_path.Append(base::FilePath(file_path)); nit: this should be ...
5 years, 11 months ago (2015-01-14 18:13:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826323002/60001
5 years, 11 months ago (2015-01-15 03:54:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/37805)
5 years, 11 months ago (2015-01-15 04:24:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826323002/60001
5 years, 11 months ago (2015-01-15 17:59:52 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-15 18:09:38 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 18:10:54 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/845a27e777ee5b8ec20deda87001c86ce59fa13e
Cr-Commit-Position: refs/heads/master@{#311693}

Powered by Google App Engine
This is Rietveld 408576698