device/usb/usb_device.h - Issue 826283002: Add support for sending a USB SET_CONFIGURATION request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/usb_device.h

Issue 826283002: Add support for sending a USB SET_CONFIGURATION request. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/device/usb/android_usb_device.cc ('K') | « chrome/browser/extensions/api/device_permissions_manager_unittest.cc ('k') | device/usb/usb_device_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/usb/usb_device.h

diff --git a/device/usb/usb_device.h b/device/usb/usb_device.h

index 8b8ec6232134ba9f3b184c42214197222ebea142..cfea8aee7fa08aba24dbd632e44326a6e930bff5 100644

--- a/device/usb/usb_device.h

+++ b/device/usb/usb_device.h

@@ -51,9 +51,10 @@ class UsbDevice : public base::RefCountedThreadSafe<UsbDevice> {

// Blocking method. Must be called on FILE thread.

virtual bool Close(scoped_refptr<UsbDeviceHandle> handle) = 0;

- // Gets the UsbConfigDescriptor for the active device configuration.

+ // Gets the UsbConfigDescriptor for the active device configuration or nullptr

+ // if the device is unconfigured.

// Blocking method. Must be called on FILE thread.

- virtual const UsbConfigDescriptor& GetConfiguration() = 0;

+ virtual const UsbConfigDescriptor* GetConfiguration() = 0;

// Gets the manufacturer string of the device, or returns false.

// Blocking method. Must be called on FILE thread.