Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: components/policy/core/common/policy_loader_mac_unittest.cc

Issue 826213004: Update {virtual,override,final} for components/ to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/storage_monitor/image_capture_device_manager_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/policy/core/common/policy_loader_mac_unittest.cc
diff --git a/components/policy/core/common/policy_loader_mac_unittest.cc b/components/policy/core/common/policy_loader_mac_unittest.cc
index a840724d937cbb21f60919dfd87748598a4740eb..3fcc78502abb834702b0ba2792ab86d55c4b2cc8 100644
--- a/components/policy/core/common/policy_loader_mac_unittest.cc
+++ b/components/policy/core/common/policy_loader_mac_unittest.cc
@@ -137,9 +137,8 @@ class PolicyLoaderMacTest : public PolicyTestBase {
protected:
PolicyLoaderMacTest()
: prefs_(new MockPreferences()) {}
- virtual ~PolicyLoaderMacTest() {}
erikwright (departed) 2015/01/09 21:06:51 Chromium guidelines encourage consistent declarati
dcheng 2015/01/09 22:09:32 The reason we declare them is so we can define the
Mattias Nissler (ping if slow) 2015/01/13 10:03:13 The reason this dtor is here is actually because t
erikwright (departed) 2015/01/13 12:03:27 I re-read C++ Dos and Don'ts, "What about code out
- virtual void SetUp() override {
+ void SetUp() override {
PolicyTestBase::SetUp();
scoped_ptr<AsyncPolicyLoader> loader(new PolicyLoaderMac(
loop_.message_loop_proxy(), base::FilePath(), prefs_));
@@ -147,7 +146,7 @@ class PolicyLoaderMacTest : public PolicyTestBase {
provider_->Init(&schema_registry_);
}
- virtual void TearDown() override {
+ void TearDown() override {
provider_->Shutdown();
PolicyTestBase::TearDown();
}
« no previous file with comments | « no previous file | components/storage_monitor/image_capture_device_manager_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698