Issue 8261004: Prevent recursive calls to globalFrameDidChange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8261004: Prevent recursive calls to globalFrameDidChange. (Closed)

Created:
9 years, 2 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 2 months ago

Reviewers:
Nico, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Prevent recursive calls to globalFrameDidChange. TEST=ran Google+ Hangout with Extras, resized window smaller; works correctly BUG=98262 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105339

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	content/browser/renderer_host/accelerated_plugin_view_mac.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	content/browser/renderer_host/accelerated_plugin_view_mac.mm	View	1	3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

Please review. Thanks. OWNERS => sky

9 years, 2 months ago (2011-10-13 02:21:18 UTC) #1

Nico

lgtm so this hangs somewhere in the system code? do you know why this started ...

9 years, 2 months ago (2011-10-13 02:26:07 UTC) #2

Ken Russell (switch to Gerrit)

9 years, 2 months ago (2011-10-13 18:41:20 UTC) #4

@thakis:

> so this hangs somewhere in the system code? do you know why this started
> happening now? or was this always broken on 10.7?

It provokes infinite recursion and a browser crash during plugin resizes. This
isn't the same as the hang bug. It looks like this was always broken on 10.7.

http://codereview.chromium.org/8261004/diff/1/content/browser/renderer_host/a...
File content/browser/renderer_host/accelerated_plugin_view_mac.mm (right):

http://codereview.chromium.org/8261004/diff/1/content/browser/renderer_host/a...
content/browser/renderer_host/accelerated_plugin_view_mac.mm:156: if
(!handlingGlobalFrameDidChange_) {
On 2011/10/13 02:26:07, Nico wrote:
> nit: early return instead, less nesting that way.

Right, thanks. Done.

Expand Messages | Collapse Messages