Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: sky/viewer/viewer.cc

Issue 826093004: Support ICU on Android (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« services/icu_data/icu_data.mojom ('K') | « sky/viewer/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/viewer/viewer.cc
diff --git a/sky/viewer/viewer.cc b/sky/viewer/viewer.cc
index d38a891a7b840288de8e1ba8b97eb0e59160c874..7db37a3a3c9009e6dfe08f842b13fc6a32b0a528 100644
--- a/sky/viewer/viewer.cc
+++ b/sky/viewer/viewer.cc
@@ -7,6 +7,7 @@
#include "base/threading/thread.h"
#include "mojo/application/application_runner_chromium.h"
#include "mojo/common/tracing_impl.h"
+#include "mojo/icu/icu.h"
#include "mojo/public/c/system/main.h"
#include "mojo/public/cpp/application/application_connection.h"
#include "mojo/public/cpp/application/application_delegate.h"
@@ -20,10 +21,6 @@
#include "sky/viewer/document_view.h"
#include "sky/viewer/platform/platform_impl.h"
-#if !defined(COMPONENT_BUILD)
-#include "base/i18n/icu_util.h"
-#endif
-
namespace sky {
// Load the viewer in testing mode so we can dump pixels.
@@ -50,11 +47,7 @@ class Viewer : public mojo::ApplicationDelegate,
platform_impl_.reset(new PlatformImpl(app));
blink::initialize(platform_impl_.get());
- // TODO(eseidel): Haven't solved ICU data loading for MojoShell.apk yet.
-#if !defined(OS_ANDROID)
- base::i18n::InitializeICU();
-#endif
-
+ mojo::icu::Initialize(app);
mojo::TracingImpl::Create(app);
}
« services/icu_data/icu_data.mojom ('K') | « sky/viewer/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698