services/icu_data/icu_data.mojom - Issue 826093004: Support ICU on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/icu_data/icu_data.mojom

Issue 826093004: Support ICU on Android (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Address review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module recipes;	5 module icu_data;
	jamesr 2015/01/08 19:03:11 re naming conventions I've tried to follow the gui re naming conventions I've tried to follow the guidance we have for C++ namespaces: http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespace_Names which says roughly to follow directory structure. Most things in //services (possibly all) use the convention that //services/{foo} is in namespace + module "foo" since the "services" bit doesn't communicate much information abarth-chromium 2015/01/08 19:08:03 SGTM. Thanks! Show quoted text On 2015/01/08 at 19:03:11, jamesr wrote: > re naming conventions I've tried to follow the guidance we have for C++ namespaces: http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespace_Names which says roughly to follow directory structure. Most things in //services (possibly all) use the convention that //services/{foo} is in namespace + module "foo" since the "services" bit doesn't communicate much information SGTM. Thanks!
6	6

7 struct Ingredient {	7 interface ICUData {

8 string url;	8 Map(string sha1hash) => (handle<shared_buffer>? icu_data);

9 };	9 };

10

11 interface Recipe {

12 GetIngredients() => (array<Ingredient> ingredients);

13 };

OLD	NEW

« no previous file with comments | « services/icu_data/embed_icu_data.py ('k') | services/icu_data/icu_data_impl.cc » ('j') | no next file with comments »