Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 82593005: Cast: Switching recevier to use media::VideoFrame (Closed)

Created:
7 years ago by mikhal
Modified:
7 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Cast: Switching recevier to use media::VideoFrame This is a follow up on a previous cl that switched Cast sender to use VideoFrame. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238536

Patch Set 1 #

Patch Set 2 : Adding media to DEPS + rebase #

Total comments: 6

Patch Set 3 : Responding to review(scherkus) #

Total comments: 2

Patch Set 4 : Added a TODO + rebase #

Patch Set 5 : Fixing includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -144 lines) Patch
M media/cast/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/cast.gyp View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M media/cast/cast_config.h View 1 chunk +0 lines, -18 lines 0 comments Download
M media/cast/cast_receiver.h View 2 chunks +6 lines, -1 line 0 comments Download
M media/cast/test/encode_decode_test.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M media/cast/test/linux_output_window.h View 2 chunks +10 lines, -2 lines 0 comments Download
M media/cast/test/linux_output_window.cc View 2 chunks +15 lines, -12 lines 0 comments Download
M media/cast/test/receiver.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cast/test/transport/transport.h View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M media/cast/test/transport/transport.cc View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M media/cast/test/video_utility.h View 1 chunk +2 lines, -7 lines 0 comments Download
M media/cast/test/video_utility.cc View 3 chunks +11 lines, -54 lines 0 comments Download
M media/cast/video_receiver/codecs/vp8/vp8_decoder.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/video_receiver/codecs/vp8/vp8_decoder.cc View 1 2 3 3 chunks +21 lines, -27 lines 0 comments Download
M media/cast/video_receiver/video_decoder.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/video_receiver/video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/video_receiver/video_receiver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
mikhal
Please review, -Mikhal
7 years ago (2013-11-22 22:46:01 UTC) #1
mikhal
ping
7 years ago (2013-11-26 16:12:28 UTC) #2
Alpha Left Google
LGTM.
7 years ago (2013-11-26 22:35:24 UTC) #3
Alpha Left Google
You might need scherkus@'s approval to add the DEPS to media. He will probably have ...
7 years ago (2013-11-26 22:36:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@google.com/82593005/1
7 years ago (2013-11-26 22:36:51 UTC) #5
mikhal1
+scherkus
7 years ago (2013-11-26 22:51:44 UTC) #6
mikhal1
scherkus - ping
7 years ago (2013-11-27 21:27:34 UTC) #7
scherkus (not reviewing)
apologies for the delay https://chromiumcodereview.appspot.com/82593005/diff/40001/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc File media/cast/video_receiver/codecs/vp8/vp8_decoder.cc (right): https://chromiumcodereview.appspot.com/82593005/diff/40001/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc#newcode89 media/cast/video_receiver/codecs/vp8/vp8_decoder.cc:89: void Vp8Decoder::CopyPlane(size_t plane, const uint8* ...
7 years ago (2013-11-27 22:21:53 UTC) #8
mikhal1
PTAL https://chromiumcodereview.appspot.com/82593005/diff/40001/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc File media/cast/video_receiver/codecs/vp8/vp8_decoder.cc (right): https://chromiumcodereview.appspot.com/82593005/diff/40001/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc#newcode89 media/cast/video_receiver/codecs/vp8/vp8_decoder.cc:89: void Vp8Decoder::CopyPlane(size_t plane, const uint8* source, int stride, ...
7 years ago (2013-11-27 22:41:29 UTC) #9
scherkus (not reviewing)
lgtm w/ question https://chromiumcodereview.appspot.com/82593005/diff/60001/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc File media/cast/video_receiver/codecs/vp8/vp8_decoder.cc (right): https://chromiumcodereview.appspot.com/82593005/diff/60001/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc#newcode73 media/cast/video_receiver/codecs/vp8/vp8_decoder.cc:73: // Copy each plane individually (need ...
7 years ago (2013-12-02 18:24:34 UTC) #10
mikhal1
https://chromiumcodereview.appspot.com/82593005/diff/60001/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc File media/cast/video_receiver/codecs/vp8/vp8_decoder.cc (right): https://chromiumcodereview.appspot.com/82593005/diff/60001/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc#newcode73 media/cast/video_receiver/codecs/vp8/vp8_decoder.cc:73: // Copy each plane individually (need to account for ...
7 years ago (2013-12-03 16:57:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@google.com/82593005/140001
7 years ago (2013-12-03 20:55:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@google.com/82593005/140001
7 years ago (2013-12-03 23:39:08 UTC) #13
commit-bot: I haz the power
7 years ago (2013-12-04 03:02:32 UTC) #14
Message was sent while issue was closed. 
Change committed as 238536

Powered by Google App Engine
This is Rietveld 408576698