src/utils.h - Issue 825913005: Avoid MSVC's C6323 warning (use of arithmetic operator on Boolean type)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils.h

Issue 825913005: Avoid MSVC's C6323 warning (use of arithmetic operator on Boolean type) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/utils.h

diff --git a/src/utils.h b/src/utils.h

index 525c6f87d3d96fbd8504a00474981675c1c1f74d..87276c1296acc338ef233088d26425b49ca5c676 100644

--- a/src/utils.h

+++ b/src/utils.h

@@ -27,6 +27,9 @@ namespace internal {

// General helper functions

+inline int BoolToInt(bool b) { return b ? 1 : 0; }

// Same as strcmp, but can handle NULL arguments.

inline bool CStringEquals(const char* s1, const char* s2) {

return (s1 == s2) || (s1 != NULL && s2 != NULL && strcmp(s1, s2) == 0);

« no previous file with comments | « src/runtime/runtime-scopes.cc ('k') | no next file » | no next file with comments »