Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 825903004: RefPtr -> SkAutoTUnref on SkStream to remove SkRefCnt. (Closed)

Created:
5 years, 11 months ago by bungeman-chromium
Modified:
5 years, 11 months ago
CC:
blink-reviews, Dominik Röttsches, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

RefPtr -> SkAutoTUnref on SkStream to remove SkRefCnt. SkStream is currently SkRefCnt, but this has never been useful, and is often a problem. As a result, SkStream will soon no longer be reference counted. RefPtr places a number of constraints on the class being reference counted, so use SkAutoTUnref in the mean time to stage the reference counting removal. The plan is to change this one instance to SkAutoTUnref, then make SkStream no longer reference counted but contain a 'dummy' unref(). The use of SkAutoTUnref here will then be removed and SkStream's 'dummy' unref() will be removed. The proposed changes to SkStream can be seen at https://codereview.chromium.org/849103004/ . Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/fonts/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
bungeman-chromium
5 years, 11 months ago (2015-01-20 17:08:07 UTC) #2
scroggo
On 2015/01/20 17:08:07, bungeman2 wrote: LGTM.
5 years, 11 months ago (2015-01-20 17:16:14 UTC) #3
bungeman-chromium
Summary of how this works for other reviewers. Currently we never take ownership of the ...
5 years, 11 months ago (2015-01-20 17:22:03 UTC) #4
bungeman-chromium
5 years, 11 months ago (2015-01-20 18:12:38 UTC) #6
eae
LGTM
5 years, 11 months ago (2015-01-20 18:40:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825903004/1
5 years, 11 months ago (2015-01-20 18:42:00 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 20:41:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188693

Powered by Google App Engine
This is Rietveld 408576698