Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 825873003: Fix for shortcut key for 'SaveAs..' are not visible in OOP PDF context menu. (Closed)

Created:
5 years, 11 months ago by Deepak
Modified:
5 years, 10 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for shortcut key for 'SaveAs..' are not visible in PDF context menu. IDC_CONTENT_CONTEXT_SAVEAVAS case added for giving accelerator key. BUG=449029 Committed: https://crrev.com/d15575438ed0a945770625e4a7b1ccaa7754ad6a Cr-Commit-Position: refs/heads/master@{#314513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Deepak
PTAL.
5 years, 11 months ago (2015-01-15 04:28:14 UTC) #2
msw
lgtm
5 years, 10 months ago (2015-02-02 20:27:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825873003/1
5 years, 10 months ago (2015-02-04 05:59:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 06:56:06 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 06:57:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d15575438ed0a945770625e4a7b1ccaa7754ad6a
Cr-Commit-Position: refs/heads/master@{#314513}

Powered by Google App Engine
This is Rietveld 408576698