Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 825853002: Expose br tag in AX Tree as ROLE_SYSTEM_WHITESPACE. (Closed)

Created:
5 years, 12 months ago by shreeramk
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, mlamouri+watch-content_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose br tag in AX Tree as ROLE_SYSTEM_WHITESPACE. BUG=116181 Committed: https://crrev.com/582e445321224238024e52876eaf19c099a26ac5 Cr-Commit-Position: refs/heads/master@{#310569}

Patch Set 1 #

Patch Set 2 : enabling tests #

Patch Set 3 : modifying test cases #

Patch Set 4 : updating expectations #

Total comments: 3

Patch Set 5 : #

Patch Set 6 : adding br as platform leaf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M chrome/common/extensions/api/automation.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 4 4 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/br-expected-android.txt View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/br-expected-mac.txt View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M content/test/data/accessibility/html/br-expected-win.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/html/dfn.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/dfn-expected-mac.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/dfn-expected-win.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/input-submit.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/legend.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/samp.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_enums.idl View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
shreeramk
aboxhall@chromium.org & dmazzoni@chromium.org: Please review. Thanks!!
5 years, 11 months ago (2015-01-07 05:52:50 UTC) #2
dmazzoni
Thanks! https://codereview.chromium.org/825853002/diff/60001/content/test/data/accessibility/html/br-expected-mac.txt File content/test/data/accessibility/html/br-expected-mac.txt (right): https://codereview.chromium.org/825853002/diff/60001/content/test/data/accessibility/html/br-expected-mac.txt#newcode1 content/test/data/accessibility/html/br-expected-mac.txt:1: #<skip -- Not Mapped> I'd prefer to see ...
5 years, 11 months ago (2015-01-07 19:32:20 UTC) #3
shreeramk
https://codereview.chromium.org/825853002/diff/60001/content/test/data/accessibility/html/br-expected-mac.txt File content/test/data/accessibility/html/br-expected-mac.txt (right): https://codereview.chromium.org/825853002/diff/60001/content/test/data/accessibility/html/br-expected-mac.txt#newcode1 content/test/data/accessibility/html/br-expected-mac.txt:1: #<skip -- Not Mapped> On 2015/01/07 19:32:19, dmazzoni wrote: ...
5 years, 11 months ago (2015-01-08 04:58:46 UTC) #4
shreeramk
@dominic: Comments incorporated. PTAL. Thanks!
5 years, 11 months ago (2015-01-08 19:00:12 UTC) #5
dmazzoni
lgtm
5 years, 11 months ago (2015-01-08 19:04:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825853002/100001
5 years, 11 months ago (2015-01-08 19:06:00 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 11 months ago (2015-01-08 19:50:00 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 19:51:36 UTC) #10
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/582e445321224238024e52876eaf19c099a26ac5
Cr-Commit-Position: refs/heads/master@{#310569}

Powered by Google App Engine
This is Rietveld 408576698