Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: Source/web/WebSettingsImpl.cpp

Issue 82583005: Use removeFontFace to avoid resetting fontSelector. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix fast/text/international/ regression Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebSettingsImpl.cpp
diff --git a/Source/web/WebSettingsImpl.cpp b/Source/web/WebSettingsImpl.cpp
index 42203da20daf33d1cd3546b393bcf2f3b00ab92c..a74681813816924d68d624a545d57a9713c77a18 100644
--- a/Source/web/WebSettingsImpl.cpp
+++ b/Source/web/WebSettingsImpl.cpp
@@ -67,36 +67,43 @@ WebSettingsImpl::WebSettingsImpl(Settings* settings)
void WebSettingsImpl::setStandardFontFamily(const WebString& font, UScriptCode script)
{
m_settings->genericFontFamilySettings().setStandard(font, script);
+ m_settings->notifyGenericFontFamilyChange();
dglazkov 2014/01/29 05:11:50 These WebSettingImpl functions are never called se
tasak 2014/01/29 10:13:43 I would like to confirm what you mean. As far as I
}
void WebSettingsImpl::setFixedFontFamily(const WebString& font, UScriptCode script)
{
m_settings->genericFontFamilySettings().setFixed(font, script);
+ m_settings->notifyGenericFontFamilyChange();
}
void WebSettingsImpl::setSerifFontFamily(const WebString& font, UScriptCode script)
{
m_settings->genericFontFamilySettings().setSerif(font, script);
+ m_settings->notifyGenericFontFamilyChange();
}
void WebSettingsImpl::setSansSerifFontFamily(const WebString& font, UScriptCode script)
{
m_settings->genericFontFamilySettings().setSansSerif(font, script);
+ m_settings->notifyGenericFontFamilyChange();
}
void WebSettingsImpl::setCursiveFontFamily(const WebString& font, UScriptCode script)
{
m_settings->genericFontFamilySettings().setCursive(font, script);
+ m_settings->notifyGenericFontFamilyChange();
}
void WebSettingsImpl::setFantasyFontFamily(const WebString& font, UScriptCode script)
{
m_settings->genericFontFamilySettings().setFantasy(font, script);
+ m_settings->notifyGenericFontFamilyChange();
}
void WebSettingsImpl::setPictographFontFamily(const WebString& font, UScriptCode script)
{
m_settings->genericFontFamilySettings().setPictograph(font, script);
+ m_settings->notifyGenericFontFamilyChange();
}
void WebSettingsImpl::setDefaultFontSize(int size)

Powered by Google App Engine
This is Rietveld 408576698