Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: remoting/webapp/crd/js/client_session.js

Issue 825793002: Remove MediaStream renderer from the webapp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/client_plugin_impl.js ('k') | remoting/webapp/crd/js/media_source_renderer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/client_session.js
diff --git a/remoting/webapp/crd/js/client_session.js b/remoting/webapp/crd/js/client_session.js
index ac8a43dd432ed46e3ac1b9937276537a7c361351..f3ae7ce9afc5069048afe50452bc20e00556cce8 100644
--- a/remoting/webapp/crd/js/client_session.js
+++ b/remoting/webapp/crd/js/client_session.js
@@ -51,17 +51,6 @@ remoting.enableCast = false;
remoting.enableMouseLock = false;
/**
- * True to enable MediaSource rendering, if available.
- * The plugin also needs to support MediaSource rendering.
- *
- * TODO(sergeyu): Remove mediaSource renderer from the plugin and
- * everywhere else.
- *
- * @type {boolean}
- */
-remoting.enableMediaSourceRendering = false;
-
-/**
* @param {remoting.SignalStrategy} signalStrategy Signal strategy.
* @param {HTMLElement} container Container element for the client view.
* @param {string} hostDisplayName A human-readable name for the host.
@@ -183,9 +172,6 @@ remoting.ClientSession = function(signalStrategy, container, hostDisplayName,
/** @private */
this.callOnFullScreenChanged_ = this.onFullScreenChanged_.bind(this)
- /** @type {HTMLMediaElement} @private */
- this.video_ = null;
-
/** @type {Element} @private */
this.mouseCursorOverlay_ =
this.container_.querySelector('.mouse-cursor-overlay');
@@ -583,27 +569,6 @@ remoting.ClientSession.prototype.onPluginInitialized_ = function(initialized) {
this.plugin_.allowMouseLock();
}
- // MediaSource-based rendering is only supported on Chrome 37 and above.
- var chromeVersionMajor =
- parseInt((remoting.getChromeVersion() || '0').split('.')[0], 10);
- if (chromeVersionMajor >= 37 &&
- remoting.enableMediaSourceRendering &&
- this.plugin_.hasFeature(
- remoting.ClientPlugin.Feature.MEDIA_SOURCE_RENDERING)) {
- this.video_ = /** @type {HTMLMediaElement} */(
- this.container_.querySelector('video'));
- // Make sure that the <video> element is hidden until we get the first
- // frame.
- this.video_.style.width = '0px';
- this.video_.style.height = '0px';
-
- var renderer = new remoting.MediaSourceRenderer(this.video_);
- this.plugin_.enableMediaSourceRendering(renderer);
- this.container_.classList.add('mediasource-rendering');
- } else {
- this.container_.classList.remove('mediasource-rendering');
- }
-
this.plugin_.setOnOutgoingIqHandler(this.sendIq_.bind(this));
this.plugin_.setOnDebugMessageHandler(this.onDebugMessage_.bind(this));
@@ -650,10 +615,6 @@ remoting.ClientSession.prototype.removePlugin = function() {
});
this.updateClientSessionUi_(null);
- // Remove mediasource-rendering class from the container - this will also
- // hide the <video> element.
- this.container_.classList.remove('mediasource-rendering');
-
this.container_.removeEventListener('mousemove',
this.updateMouseCursorPosition_,
true);
@@ -1345,11 +1306,6 @@ remoting.ClientSession.prototype.updateDimensions = function() {
var pluginWidth = Math.round(desktopWidth * scale);
var pluginHeight = Math.round(desktopHeight * scale);
- if (this.video_) {
- this.video_.style.width = pluginWidth + 'px';
- this.video_.style.height = pluginHeight + 'px';
- }
-
// Resize the plugin if necessary.
// TODO(wez): Handle high-DPI to high-DPI properly (crbug.com/135089).
this.plugin_.element().style.width = pluginWidth + 'px';
« no previous file with comments | « remoting/webapp/crd/js/client_plugin_impl.js ('k') | remoting/webapp/crd/js/media_source_renderer.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698