Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 825783003: Ozone: Fix Linux Build. (Closed)

Created:
5 years, 11 months ago by kalyank
Modified:
5 years, 11 months ago
Reviewers:
sky, spang
CC:
chromium-reviews, kalyank, tfarina, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ozone: Fix Linux Build. https://codereview.chromium.org/831863003 has enabled strict checks for {virtual,override,final} on Linux. This CL fixes build issues for Ozone on Linux. BUG=417463 Committed: https://crrev.com/bc77da799aece5b9fb2226cf93abfccfc1d2b2db Cr-Commit-Position: refs/heads/master@{#310136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M ash/host/ash_window_tree_host_ozone.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/global_shortcut_listener_ozone.h View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kalyank
5 years, 11 months ago (2015-01-06 09:53:50 UTC) #2
sky
LGTM
5 years, 11 months ago (2015-01-06 16:48:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825783003/1
5 years, 11 months ago (2015-01-06 20:34:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 20:48:06 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 20:49:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc77da799aece5b9fb2226cf93abfccfc1d2b2db
Cr-Commit-Position: refs/heads/master@{#310136}

Powered by Google App Engine
This is Rietveld 408576698