components/password_manager/core/browser/password_syncable_service.cc - Issue 825773003: PasswordStore: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_syncable_service.cc

Issue 825773003: PasswordStore: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use assignment instead of construction Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store_sync.h ('k') | components/password_manager/core/browser/test_password_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_syncable_service.cc

diff --git a/components/password_manager/core/browser/password_syncable_service.cc b/components/password_manager/core/browser/password_syncable_service.cc

index 8438b2a7251c1d1e4bcf7122b81b21a003d6c096..5e07e7e35fbbbdfc8fa3713c0e94ef8b3ac1f5b6 100644

--- a/components/password_manager/core/browser/password_syncable_service.cc

+++ b/components/password_manager/core/browser/password_syncable_service.cc

@@ -303,8 +303,8 @@ bool PasswordSyncableService::ReadFromPasswordStore(

ScopedVector<autofill::PasswordForm>* password_entries,

PasswordEntryMap* passwords_entry_map) const {

DCHECK(password_entries);

- if (!password_store_->FillAutofillableLogins(&password_entries->get()) ||

- !password_store_->FillBlacklistLogins(&password_entries->get())) {

+ if (!password_store_->FillAutofillableLogins(password_entries) ||

+ !password_store_->FillBlacklistLogins(password_entries)) {

// Password store often fails to load passwords. Track failures with UMA.

// (http://crbug.com/249000)

UMA_HISTOGRAM_ENUMERATION("Sync.LocalDataFailedToLoad",