Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x.h

Issue 825773003: PasswordStore: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use assignment instead of construction Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/native_backend_gnome_x.h
diff --git a/chrome/browser/password_manager/native_backend_gnome_x.h b/chrome/browser/password_manager/native_backend_gnome_x.h
index f6e2ddb6f288d8e781260f54c73250e8bec1652e..438917a5e009e69a0d92fc5802e092d0db41d404 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x.h
+++ b/chrome/browser/password_manager/native_backend_gnome_x.h
@@ -20,6 +20,7 @@
#include <string>
#include "base/basictypes.h"
+#include "base/memory/scoped_vector.h"
#include "base/time/time.h"
#include "chrome/browser/password_manager/password_store_factory.h"
#include "chrome/browser/password_manager/password_store_x.h"
@@ -105,9 +106,10 @@ class NativeBackendGnome : public PasswordStoreX::NativeBackend,
base::Time delete_end,
password_manager::PasswordStoreChangeList* changes) override;
bool GetLogins(const autofill::PasswordForm& form,
- PasswordFormList* forms) override;
- bool GetAutofillableLogins(PasswordFormList* forms) override;
- bool GetBlacklistLogins(PasswordFormList* forms) override;
+ ScopedVector<autofill::PasswordForm>* forms) override;
+ bool GetAutofillableLogins(
+ ScopedVector<autofill::PasswordForm>* forms) override;
+ bool GetBlacklistLogins(ScopedVector<autofill::PasswordForm>* forms) override;
private:
enum TimestampToCompare {
@@ -119,17 +121,18 @@ class NativeBackendGnome : public PasswordStoreX::NativeBackend,
bool RawAddLogin(const autofill::PasswordForm& form);
// Reads PasswordForms from the keyring with the given autofillability state.
- bool GetLoginsList(PasswordFormList* forms, bool autofillable);
+ bool GetLoginsList(bool autofillable,
+ ScopedVector<autofill::PasswordForm>* forms);
// Helper for GetLoginsCreatedBetween().
- bool GetAllLogins(PasswordFormList* forms);
+ bool GetAllLogins(ScopedVector<autofill::PasswordForm>* forms);
// Retrieves password created/synced in the time interval. Returns |true| if
// the operation succeeded.
bool GetLoginsBetween(base::Time get_begin,
base::Time get_end,
TimestampToCompare date_to_compare,
- PasswordFormList* forms);
+ ScopedVector<autofill::PasswordForm>* forms);
// Removes password created/synced in the time interval. Returns |true| if the
// operation succeeded. |changes| will contain the changes applied.
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698