chrome/browser/password_manager/password_store_win.h - Issue 825773003: PasswordStore: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_win.h

Issue 825773003: PasswordStore: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix one more use-after-free Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_store_mac_unittest.cc ('K') | « chrome/browser/password_manager/password_store_mac_unittest.cc ('k') | chrome/browser/password_manager/password_store_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_win.h

diff --git a/chrome/browser/password_manager/password_store_win.h b/chrome/browser/password_manager/password_store_win.h

index e3fcace379cb4c8543d46fe8eb8a97ab70a20b82..9d96dc4c3692d8c9b8769e3648541ac18a7cd131 100644

--- a/chrome/browser/password_manager/password_store_win.h

+++ b/chrome/browser/password_manager/password_store_win.h

@@ -6,6 +6,7 @@

#define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_WIN_H_

#include "base/memory/scoped_ptr.h"

+#include "base/memory/scoped_vector.h"

#include "components/password_manager/core/browser/password_store_default.h"

class PasswordWebDataService;

@@ -48,9 +49,9 @@ class PasswordStoreWin : public password_manager::PasswordStoreDefault {

const ConsumerCallbackRunner& callback_runner) override;

void GetIE7LoginIfNecessary(

- const autofill::PasswordForm& form,

- const ConsumerCallbackRunner& callback_runner,

- const std::vector<autofill::PasswordForm*>& matched_forms);

+ const autofill::PasswordForm& form,

+ const ConsumerCallbackRunner& callback_runner,

+ ScopedVector<autofill::PasswordForm> matched_forms);

scoped_ptr<DBHandler> db_handler_;