components/password_manager/core/browser/password_store_sync.h - Issue 825773003: PasswordStore: Use ScopedVector to express ownership of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_sync.h

Issue 825773003: PasswordStore: Use ScopedVector to express ownership of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Leaks fixed + VABR->vabr Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_store_default.cc ('K') | « components/password_manager/core/browser/password_store_default.cc ('k') | components/password_manager/core/browser/password_syncable_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_sync.h

diff --git a/components/password_manager/core/browser/password_store_sync.h b/components/password_manager/core/browser/password_store_sync.h

index d984bad4a3a20dcd3aef404c85705e2467b0f4cb..bed837a3752ce3a11754bbf252e508450ab4817b 100644

--- a/components/password_manager/core/browser/password_store_sync.h

+++ b/components/password_manager/core/browser/password_store_sync.h

@@ -5,8 +5,7 @@

#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_SYNC_INTERFACE_H_

#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_SYNC_INTERFACE_H_

-#include <vector>

+#include "base/memory/scoped_vector.h"

#include "components/password_manager/core/browser/password_store_change.h"

namespace password_manager {

@@ -19,11 +18,11 @@ class PasswordStoreSync {

public:

// Finds all non-blacklist PasswordForms, and fills the vector.

virtual bool FillAutofillableLogins(

- std::vector<autofill::PasswordForm*>* forms) = 0;

+ ScopedVector<autofill::PasswordForm>* forms) = 0;

// Finds all blacklist PasswordForms, and fills the vector.

virtual bool FillBlacklistLogins(

- std::vector<autofill::PasswordForm*>* forms) = 0;

+ ScopedVector<autofill::PasswordForm>* forms) = 0;

// Synchronous implementation to add the given login.

virtual PasswordStoreChangeList AddLoginImpl(